mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
	Pavel Machek <pavel@ucw.cz>, Marc Zyngier <marc.zyngier@arm.com>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)
Date: Sun, 4 Jan 2015 20:43:23 +0000	[thread overview]
Message-ID: <20150104204323.GA12302@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CA+55aFxMbicJZXzzHc8=vdwCzhz4kdrmZEKjLadZXr7aySZ4zg@mail.gmail.com>

On Sun, Jan 04, 2015 at 12:22:36PM -0800, Linus Torvalds wrote:
> On Sun, Jan 4, 2015 at 12:03 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> >
> > NAK.
> 
> To quote the standard response for people who ignore regressions:
> 
>   "SHUT THE FUCK UP"
> 
> you cannot NAK regression fixes. Seriously.

How about we calm down and take some informed view instead of throwing
mud?  I'd never thought I'd have to be doing this but it seems necessary.

Yes, it's bad that we now have a userspace breakage from removing the
bogomips, but a simple revert of the patch doesn't fix it properly.  It
_may_ seem to get things going again by providing a value, but that
value may not be what was once provided back in the days that these
programs were written.

The problem is that we now have hardware timers providing the kernel's
delay implementation, which makes the published "bogomips" value no
longer meaningful for the CPU speed.

So, merely reverting the patch doesn't fix the problem.  So, Nico's
NAK on the simple revert is quite right.

Instead of throwing insults, what we need to do is to approach this
calmly, and work out what we can do to fix it properly.

I'm *not* going to be looking at this until at least mid-week because
I'm still on my Christmas break, but also I'm unwell which has left me
severely lacking sleep.  If others want to do all the necessary
research, then be my guest.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-01-04 20:43 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 19:01 Pavel Machek
2015-01-04 20:03 ` Nicolas Pitre
2015-01-04 20:10   ` Pavel Machek
2015-01-04 20:25     ` Nicolas Pitre
2015-01-04 20:37       ` Pavel Machek
2015-01-04 20:56         ` Nicolas Pitre
2015-01-04 21:02           ` Linus Torvalds
2015-01-04 21:20             ` Nicolas Pitre
2015-01-04 21:26               ` Russell King - ARM Linux
2015-01-04 21:40                 ` Pavel Machek
2015-01-04 22:27                   ` Aaro Koskinen
2015-01-05  1:34                 ` Theodore Ts'o
2015-01-05 12:32                   ` Will Deacon
2015-01-05  4:51                 ` Nicolas Pitre
2015-01-05 12:11                   ` Will Deacon
2015-01-05 15:34                     ` Pavel Machek
2015-01-05 16:24                     ` Nicolas Pitre
2015-01-07 18:11                   ` Catalin Marinas
2015-01-07 18:47                     ` Linus Torvalds
2015-01-07 19:00                       ` Nicolas Pitre
2015-01-07 19:36                         ` Linus Torvalds
2015-01-07 20:34                           ` Nicolas Pitre
2015-01-07 20:53                             ` Russell King - ARM Linux
2015-01-07 21:15                               ` Nicolas Pitre
2015-01-09 22:54                                 ` Steven Rostedt
2015-01-07 22:14                               ` Catalin Marinas
2015-01-08  0:05                                 ` Linus Torvalds
2015-01-08  0:45                                   ` Nicolas Pitre
2015-01-08  0:57                                     ` Linus Torvalds
2015-01-08  4:56                                       ` Nicolas Pitre
2015-01-08  5:04                                         ` Linus Torvalds
2015-01-08  5:54                                           ` Nicolas Pitre
2015-01-08 10:39                                 ` Russell King - ARM Linux
2015-01-08 15:44                                   ` Vince Weaver
2015-01-08 16:19                                     ` Catalin Marinas
2015-01-08 16:34                                       ` Russell King - ARM Linux
2015-01-08 16:41                                         ` Catalin Marinas
2015-01-08 16:57                                           ` Russell King - ARM Linux
2015-01-08 17:01                                             ` Catalin Marinas
2015-01-08 17:39                                               ` Vince Weaver
2015-01-08 17:22                                             ` Vince Weaver
2015-01-08 22:46                                             ` Pavel Machek
2015-01-09  9:49                                               ` Catalin Marinas
2015-01-08 16:32                                     ` Russell King - ARM Linux
     [not found]                             ` <CA+55aFwuO2g1S-bY96V28crMWj+dKXWANzbP28JQjBdTg0rV0w@mail.gmail.com>
2015-01-07 21:29                               ` Nicolas Pitre
     [not found]                                 ` <CA+55aFyrNE9qqBR9Khbj=TuAnjA+UzUhNxFz==SqKuiG5q3uMQ@mail.gmail.com>
2015-01-07 22:42                                   ` Nicolas Pitre
2015-01-08  0:25                                     ` Linus Torvalds
2015-01-08  0:49                                       ` Linus Torvalds
2015-01-07 22:24                           ` Catalin Marinas
2015-01-07 18:50                     ` Nicolas Pitre
2015-01-08 22:49                   ` Pavel Machek
2015-01-06 18:33         ` Will Deacon
2015-01-04 20:22   ` Linus Torvalds
2015-01-04 20:43     ` Russell King - ARM Linux [this message]
2015-01-04 20:52       ` Pavel Machek
2015-01-04 20:45     ` Nicolas Pitre
2015-01-04 20:57       ` Linus Torvalds
2015-01-04 21:15         ` Russell King - ARM Linux
2015-01-05 14:22           ` One Thousand Gnomes
2015-01-05 18:22             ` Catalin Marinas
2015-01-06 22:33               ` Linus Torvalds
2015-01-06 23:42                 ` Catalin Marinas
2015-01-07  1:20                   ` Linus Torvalds
2015-01-07 15:01                     ` Catalin Marinas
2015-01-08 13:29                       ` One Thousand Gnomes
2015-01-07  6:41                   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150104204323.GA12302@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®