From: Catalin Marinas <catalin.marinas@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Marc Zyngier <Marc.Zyngier@arm.com>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)
Date: Wed, 7 Jan 2015 15:01:36 +0000 [thread overview]
Message-ID: <20150107150136.GC2199@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <CA+55aFw8x01fBKczTSNkAZ06rwULVp0A=pASJACs8S1SB_Orew@mail.gmail.com>
On Wed, Jan 07, 2015 at 01:20:06AM +0000, Linus Torvalds wrote:
> On Tue, Jan 6, 2015 at 3:42 PM, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >>
> >> That's what bogomips *is*, for chrissake! It's a bogus measure of how
> >> many times you go through the delay loop.
> >
> > I think that's where the misunderstanding is. We don't have any idea
> > how many times we go through the delay loop. We just go through the
> > delay loop until the counter (driven by an independent frequency)
> > changes X times.
>
> .. and that's exactly what we do on x86 too with the TSC. It's fine.
I may be mistaken but isn't TSC somehow related to the CPU frequency on
x86?
On ARM, the generic/architected timer is not. It's just a timer+counter
(used as clocksource and event generator in Linux) clocked at a
frequency completely independent from the CPU frequency, *no* relation
between the two.
I think a better comparison would be to HPET rather than TSC. But on x86
we use HPET to calibrate the TSC and use the TSC for the delay loop. If
on x86 the BogoMIPS was changed to report the HPET frequency, would you
be ok with it?
> > With the current arm timer-based (and arm64) implementation, the
> > reported BogoMIPS has nothing to do with the CPU benchmark. It just
> > tells you that a X MHz counter needs X*1000000/HZ ticks per jiffy.
>
> Yes. And that's a valid bogomips. We've done that for ages on x86.
See above, my understanding of TSC is that the x86 BogoMIPS is at least
in some way closely related to the CPU frequency. That's more like a
perf counter on ARM counting the CPU cycles but we don't use it for
udelay() (as it may or may not be enabled in a production system).
--
Catalin
next prev parent reply other threads:[~2015-01-07 15:01 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 19:01 Pavel Machek
2015-01-04 20:03 ` Nicolas Pitre
2015-01-04 20:10 ` Pavel Machek
2015-01-04 20:25 ` Nicolas Pitre
2015-01-04 20:37 ` Pavel Machek
2015-01-04 20:56 ` Nicolas Pitre
2015-01-04 21:02 ` Linus Torvalds
2015-01-04 21:20 ` Nicolas Pitre
2015-01-04 21:26 ` Russell King - ARM Linux
2015-01-04 21:40 ` Pavel Machek
2015-01-04 22:27 ` Aaro Koskinen
2015-01-05 1:34 ` Theodore Ts'o
2015-01-05 12:32 ` Will Deacon
2015-01-05 4:51 ` Nicolas Pitre
2015-01-05 12:11 ` Will Deacon
2015-01-05 15:34 ` Pavel Machek
2015-01-05 16:24 ` Nicolas Pitre
2015-01-07 18:11 ` Catalin Marinas
2015-01-07 18:47 ` Linus Torvalds
2015-01-07 19:00 ` Nicolas Pitre
2015-01-07 19:36 ` Linus Torvalds
2015-01-07 20:34 ` Nicolas Pitre
2015-01-07 20:53 ` Russell King - ARM Linux
2015-01-07 21:15 ` Nicolas Pitre
2015-01-09 22:54 ` Steven Rostedt
2015-01-07 22:14 ` Catalin Marinas
2015-01-08 0:05 ` Linus Torvalds
2015-01-08 0:45 ` Nicolas Pitre
2015-01-08 0:57 ` Linus Torvalds
2015-01-08 4:56 ` Nicolas Pitre
2015-01-08 5:04 ` Linus Torvalds
2015-01-08 5:54 ` Nicolas Pitre
2015-01-08 10:39 ` Russell King - ARM Linux
2015-01-08 15:44 ` Vince Weaver
2015-01-08 16:19 ` Catalin Marinas
2015-01-08 16:34 ` Russell King - ARM Linux
2015-01-08 16:41 ` Catalin Marinas
2015-01-08 16:57 ` Russell King - ARM Linux
2015-01-08 17:01 ` Catalin Marinas
2015-01-08 17:39 ` Vince Weaver
2015-01-08 17:22 ` Vince Weaver
2015-01-08 22:46 ` Pavel Machek
2015-01-09 9:49 ` Catalin Marinas
2015-01-08 16:32 ` Russell King - ARM Linux
[not found] ` <CA+55aFwuO2g1S-bY96V28crMWj+dKXWANzbP28JQjBdTg0rV0w@mail.gmail.com>
2015-01-07 21:29 ` Nicolas Pitre
[not found] ` <CA+55aFyrNE9qqBR9Khbj=TuAnjA+UzUhNxFz==SqKuiG5q3uMQ@mail.gmail.com>
2015-01-07 22:42 ` Nicolas Pitre
2015-01-08 0:25 ` Linus Torvalds
2015-01-08 0:49 ` Linus Torvalds
2015-01-07 22:24 ` Catalin Marinas
2015-01-07 18:50 ` Nicolas Pitre
2015-01-08 22:49 ` Pavel Machek
2015-01-06 18:33 ` Will Deacon
2015-01-04 20:22 ` Linus Torvalds
2015-01-04 20:43 ` Russell King - ARM Linux
2015-01-04 20:52 ` Pavel Machek
2015-01-04 20:45 ` Nicolas Pitre
2015-01-04 20:57 ` Linus Torvalds
2015-01-04 21:15 ` Russell King - ARM Linux
2015-01-05 14:22 ` One Thousand Gnomes
2015-01-05 18:22 ` Catalin Marinas
2015-01-06 22:33 ` Linus Torvalds
2015-01-06 23:42 ` Catalin Marinas
2015-01-07 1:20 ` Linus Torvalds
2015-01-07 15:01 ` Catalin Marinas [this message]
2015-01-08 13:29 ` One Thousand Gnomes
2015-01-07 6:41 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107150136.GC2199@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=pavel@ucw.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®