* [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
@ 2015-02-11 16:24 Josh Boyer
2015-02-11 20:39 ` Arnaldo Carvalho de Melo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Josh Boyer @ 2015-02-11 16:24 UTC (permalink / raw)
To: Vineet Gupta, Jiri Olsa, Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Ingo Molnar, linux-kernel
The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must
be defined before pthread.h is included in order to get the proper function
declaration. Define this in the Makefile.
Without this defined, the feature check fails on a Fedora system with gcc5
and then the perf build later fails with conflicting prototypes for the
function.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
tools/perf/config/feature-checks/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Full logs at:
http://koji.fedoraproject.org/koji/getfile?taskID=8895543&name=build.log
diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
index 42ac05aaf8ac..b32ff3372514 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -49,7 +49,7 @@ test-hello.bin:
$(BUILD)
test-pthread-attr-setaffinity-np.bin:
- $(BUILD) -Werror -lpthread
+ $(BUILD) -D_GNU_SOURCE -Werror -lpthread
test-stackprotector-all.bin:
$(BUILD) -Werror -fstack-protector-all
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
2015-02-11 16:24 [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check Josh Boyer
@ 2015-02-11 20:39 ` Arnaldo Carvalho de Melo
2015-02-18 18:30 ` [tip:perf/core] " tip-bot for Josh Boyer
2015-03-01 16:49 ` [tip:perf/urgent] " tip-bot for Josh Boyer
2 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-02-11 20:39 UTC (permalink / raw)
To: Josh Boyer
Cc: Vineet Gupta, Jiri Olsa, Peter Zijlstra, Ingo Molnar, linux-kernel
Em Wed, Feb 11, 2015 at 11:24:05AM -0500, Josh Boyer escreveu:
> The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must
> be defined before pthread.h is included in order to get the proper function
> declaration. Define this in the Makefile.
>
> Without this defined, the feature check fails on a Fedora system with gcc5
> and then the perf build later fails with conflicting prototypes for the
> function.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> tools/perf/config/feature-checks/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
2015-02-11 16:24 [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check Josh Boyer
2015-02-11 20:39 ` Arnaldo Carvalho de Melo
@ 2015-02-18 18:30 ` tip-bot for Josh Boyer
2015-03-01 16:49 ` [tip:perf/urgent] " tip-bot for Josh Boyer
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Josh Boyer @ 2015-02-18 18:30 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, Vineet.Gupta1, jwboyer, a.p.zijlstra, hpa, jolsa,
linux-kernel, mingo, acme
Commit-ID: 39f5704399042fff5f0d5f6af32bbbc3e787a897
Gitweb: http://git.kernel.org/tip/39f5704399042fff5f0d5f6af32bbbc3e787a897
Author: Josh Boyer <jwboyer@fedoraproject.org>
AuthorDate: Wed, 11 Feb 2015 11:24:05 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 11 Feb 2015 17:38:55 -0300
perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE
must be defined before pthread.h is included in order to get the proper
function declaration. Define this in the Makefile.
Without this defined, the feature check fails on a Fedora system with
gcc5 and then the perf build later fails with conflicting prototypes for
the function.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Link: http://lkml.kernel.org/r/20150211162404.GA15522@hansolo.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/feature-checks/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
index 42ac05a..b32ff33 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -49,7 +49,7 @@ test-hello.bin:
$(BUILD)
test-pthread-attr-setaffinity-np.bin:
- $(BUILD) -Werror -lpthread
+ $(BUILD) -D_GNU_SOURCE -Werror -lpthread
test-stackprotector-all.bin:
$(BUILD) -Werror -fstack-protector-all
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/urgent] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
2015-02-11 16:24 [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check Josh Boyer
2015-02-11 20:39 ` Arnaldo Carvalho de Melo
2015-02-18 18:30 ` [tip:perf/core] " tip-bot for Josh Boyer
@ 2015-03-01 16:49 ` tip-bot for Josh Boyer
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Josh Boyer @ 2015-03-01 16:49 UTC (permalink / raw)
To: linux-tip-commits
Cc: jwboyer, Vineet.Gupta1, mingo, jolsa, a.p.zijlstra, tglx, acme,
hpa, linux-kernel
Commit-ID: 8eb733829cd17b9b66971f08110df7224d391d65
Gitweb: http://git.kernel.org/tip/8eb733829cd17b9b66971f08110df7224d391d65
Author: Josh Boyer <jwboyer@fedoraproject.org>
AuthorDate: Wed, 11 Feb 2015 11:24:05 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 25 Feb 2015 12:17:38 -0300
perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE
must be defined before pthread.h is included in order to get the proper
function declaration. Define this in the Makefile.
Without this defined, the feature check fails on a Fedora system with
gcc5 and then the perf build later fails with conflicting prototypes for
the function.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Link: http://lkml.kernel.org/r/20150211162404.GA15522@hansolo.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/feature-checks/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
index 42ac05a..b32ff33 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -49,7 +49,7 @@ test-hello.bin:
$(BUILD)
test-pthread-attr-setaffinity-np.bin:
- $(BUILD) -Werror -lpthread
+ $(BUILD) -D_GNU_SOURCE -Werror -lpthread
test-stackprotector-all.bin:
$(BUILD) -Werror -fstack-protector-all
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-01 16:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-11 16:24 [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check Josh Boyer
2015-02-11 20:39 ` Arnaldo Carvalho de Melo
2015-02-18 18:30 ` [tip:perf/core] " tip-bot for Josh Boyer
2015-03-01 16:49 ` [tip:perf/urgent] " tip-bot for Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome