* [PATCH v2] staging: lustre: fld_request.c: Remove else after return.
@ 2015-02-28 16:37 Alberto Pires de Oliveira Neto
2015-03-02 1:30 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Alberto Pires de Oliveira Neto @ 2015-02-28 16:37 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, gregkh
Cc: linux-kernel, Alberto Pires de Oliveira Neto
This patch fixes checkpatch.pl warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
index b8d17e1..0b00301 100644
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld,
CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
fld->lcf_name, name, tar->ft_idx);
return 0;
- } else {
- CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
- fld->lcf_name, name, tar->ft_idx);
- }
+ }
+ CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
+ fld->lcf_name, name, tar->ft_idx);
OBD_ALLOC_PTR(target);
if (target == NULL)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after return.
2015-02-28 16:37 [PATCH v2] staging: lustre: fld_request.c: Remove else after return Alberto Pires de Oliveira Neto
@ 2015-03-02 1:30 ` Greg KH
2015-03-02 1:45 ` Alberto Pires de Oliveira Neto
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2015-03-02 1:30 UTC (permalink / raw)
To: Alberto Pires de Oliveira Neto; +Cc: oleg.drokin, andreas.dilger, linux-kernel
On Sat, Feb 28, 2015 at 01:37:23PM -0300, Alberto Pires de Oliveira Neto wrote:
> This patch fixes checkpatch.pl warning.
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
> ---
> drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
> index b8d17e1..0b00301 100644
> --- a/drivers/staging/lustre/lustre/fld/fld_request.c
> +++ b/drivers/staging/lustre/lustre/fld/fld_request.c
> @@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld,
> CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
> fld->lcf_name, name, tar->ft_idx);
> return 0;
> - } else {
> - CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
> - fld->lcf_name, name, tar->ft_idx);
> - }
> + }
> + CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
> + fld->lcf_name, name, tar->ft_idx);
>
> OBD_ALLOC_PTR(target);
> if (target == NULL)
Never add new checkpatch errors when trying to fix checkpatch errors, as
you will never end up removing them...
Please fix and resend.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after return.
2015-03-02 1:30 ` Greg KH
@ 2015-03-02 1:45 ` Alberto Pires de Oliveira Neto
0 siblings, 0 replies; 3+ messages in thread
From: Alberto Pires de Oliveira Neto @ 2015-03-02 1:45 UTC (permalink / raw)
To: Greg KH; +Cc: oleg.drokin, andreas.dilger, linux-kernel
that's true.
I think it's ok now.
On Sun, Mar 1, 2015 at 10:30 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Feb 28, 2015 at 01:37:23PM -0300, Alberto Pires de Oliveira Neto wrote:
>> This patch fixes checkpatch.pl warning.
>> WARNING: else is not generally useful after a break or return
>>
>> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
>> index b8d17e1..0b00301 100644
>> --- a/drivers/staging/lustre/lustre/fld/fld_request.c
>> +++ b/drivers/staging/lustre/lustre/fld/fld_request.c
>> @@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld,
>> CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
>> fld->lcf_name, name, tar->ft_idx);
>> return 0;
>> - } else {
>> - CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
>> - fld->lcf_name, name, tar->ft_idx);
>> - }
>> + }
>> + CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
>> + fld->lcf_name, name, tar->ft_idx);
>>
>> OBD_ALLOC_PTR(target);
>> if (target == NULL)
>
> Never add new checkpatch errors when trying to fix checkpatch errors, as
> you will never end up removing them...
>
> Please fix and resend.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-02 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-28 16:37 [PATCH v2] staging: lustre: fld_request.c: Remove else after return Alberto Pires de Oliveira Neto
2015-03-02 1:30 ` Greg KH
2015-03-02 1:45 ` Alberto Pires de Oliveira Neto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®