From: Borislav Petkov <bp@suse.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andre Przywara <andre.przywara@arm.com>,
x86@kernel.org
Subject: Re: [PATCH v3] x86: move cacheinfo sysfs to generic cacheinfo infrastructure
Date: Thu, 5 Mar 2015 09:16:40 +0100 [thread overview]
Message-ID: <20150305081640.GA3817@pd.tnic> (raw)
In-Reply-To: <20150304122720.GD3663@pd.tnic>
On Wed, Mar 04, 2015 at 01:27:20PM +0100, Borislav Petkov wrote:
> Applied, thanks guys.
Ok, we forgot to add the same check in the cpu_has_topoext case in
__cache_amd_cpumap_setup() and my F15h exploded this morning:
---
diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 54e43d58e714..8008bc2dd2d0 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -820,9 +820,13 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index,
for_each_online_cpu(i) {
this_cpu_ci = get_cpu_cacheinfo(i);
+ if (!this_cpu_ci->info_list)
+ continue;
+
apicid = cpu_data(i).apicid;
if ((apicid < first) || (apicid > last))
continue;
+
this_leaf = this_cpu_ci->info_list + index;
for_each_online_cpu(sibling) {
---
I've folded the above into your patch.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-03-05 8:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 7:50 [PATCH RFT] " Sudeep Holla
2015-01-23 13:55 ` Thomas Gleixner
2015-01-23 18:15 ` Borislav Petkov
2015-02-23 16:36 ` Sudeep Holla
2015-02-23 18:14 ` [PATCH RFT v2] " Sudeep Holla
2015-02-24 7:58 ` Ingo Molnar
2015-02-24 9:30 ` Sudeep Holla
2015-02-24 17:57 ` Borislav Petkov
2015-02-24 18:09 ` Sudeep Holla
2015-02-24 18:58 ` Borislav Petkov
2015-03-01 22:39 ` Andre Przywara
2015-03-02 10:17 ` Sudeep Holla
2015-03-03 18:45 ` Borislav Petkov
2015-03-03 18:53 ` Tejun Heo
2015-03-03 18:57 ` Borislav Petkov
2015-03-04 11:15 ` Sudeep Holla
2015-03-04 11:27 ` Borislav Petkov
2015-03-04 11:35 ` Sudeep Holla
2015-03-04 9:52 ` Sudeep Holla
2015-03-04 12:00 ` [PATCH v3] " Sudeep Holla
2015-03-04 12:27 ` Borislav Petkov
2015-03-05 8:16 ` Borislav Petkov [this message]
2015-03-05 9:28 ` Sudeep Holla
2015-03-10 11:37 ` Borislav Petkov
2015-03-10 11:53 ` Sudeep Holla
2015-03-10 14:22 ` Sudeep Holla
2015-03-10 14:26 ` Borislav Petkov
2015-03-10 14:35 ` Sudeep Holla
2015-03-11 13:36 ` Borislav Petkov
2015-03-11 15:44 ` Sudeep Holla
2015-03-11 20:23 ` Borislav Petkov
2015-03-09 14:46 ` [tip:x86/cpu] x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure tip-bot for Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305081640.GA3817@pd.tnic \
--to=bp@suse.de \
--cc=andre.przywara@arm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome