From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com,
fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com,
patrick.marlier@gmail.com, davem@davemloft.net
Subject: Re: [PATCH tip/core/rcu 4/4] netfilter: Fix list_entry_rcu usage
Date: Tue, 12 May 2015 22:42:46 -0400 [thread overview]
Message-ID: <20150512224246.45ce863e@grimm.local.home> (raw)
In-Reply-To: <1431470787-4702-4-git-send-email-paulmck@linux.vnet.ibm.com>
On Tue, 12 May 2015 15:46:27 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> From: Patrick Marlier <patrick.marlier@gmail.com>
>
> Signed-off-by: Patrick Marlier <patrick.marlier@gmail.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> net/netfilter/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/core.c b/net/netfilter/core.c
> index e6163017c42d..ad70195929a4 100644
> --- a/net/netfilter/core.c
> +++ b/net/netfilter/core.c
> @@ -166,7 +166,7 @@ int nf_hook_slow(struct sk_buff *skb, struct nf_hook_state *state)
> /* We may already have this, but read-locks nest anyway */
> rcu_read_lock();
>
> - elem = list_entry_rcu(&nf_hooks[state->pf][state->hook],
> + elem = list_entry_rcu(nf_hooks[state->pf][state->hook].next,
> struct nf_hook_ops, list);
Looks to be setting to the next element, not the current one.
-- Steve
> next_hook:
> verdict = nf_iterate(&nf_hooks[state->pf][state->hook], skb, state,
prev parent reply other threads:[~2015-05-13 2:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 22:46 [PATCH tip/core/rcu 0/4] RCU-protected list updates for 4.2 Paul E. McKenney
2015-05-12 22:46 ` [PATCH tip/core/rcu 1/4] rculist: Fix another sparse warning Paul E. McKenney
2015-05-12 22:46 ` [PATCH tip/core/rcu 2/4] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw Paul E. McKenney
2015-05-12 22:46 ` [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage Paul E. McKenney
2015-05-13 2:38 ` Steven Rostedt
2015-05-13 2:58 ` NeilBrown
2015-05-13 13:17 ` Paul E. McKenney
2015-05-16 17:42 ` Patrick Marlier
2015-05-18 2:06 ` NeilBrown
2015-05-18 13:43 ` Steven Rostedt
2015-05-19 22:07 ` Paul E. McKenney
2015-05-20 5:09 ` NeilBrown
2015-05-20 13:28 ` Paul E. McKenney
2015-05-21 0:07 ` NeilBrown
2015-09-11 23:05 ` Paul E. McKenney
2015-09-13 10:06 ` Patrick Marlier
2015-09-13 16:10 ` Paul E. McKenney
2015-09-22 20:50 ` Paul E. McKenney
2015-09-23 17:57 ` Patrick Marlier
2015-09-24 4:45 ` Paul E. McKenney
2015-05-18 13:53 ` Patrick Marlier
2015-05-18 19:36 ` Patrick Marlier
2015-05-12 22:46 ` [PATCH tip/core/rcu 4/4] netfilter: " Paul E. McKenney
2015-05-13 2:42 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512224246.45ce863e@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=patrick.marlier@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®