From: Dave Jones <davej@codemonkey.org.uk>
To: Prarit Bhargava <prarit@redhat.com>
Cc: John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Jan Kara <jack@suse.cz>, Jiri Bohac <jbohac@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 0/5 v2] Fixes for leapsecond expiring early ABS_TIME CLOCK_REALTIME timers
Date: Fri, 12 Jun 2015 10:59:59 -0400 [thread overview]
Message-ID: <20150612145958.GB22489@codemonkey.org.uk> (raw)
In-Reply-To: <557AF2FD.2070606@redhat.com>
On Fri, Jun 12, 2015 at 10:55:57AM -0400, Prarit Bhargava wrote:
> > > This series has only had limited testing, so I wanted to send
> > > it out for initial review and comment. Folks can grab this tree
> > > via git for testing here:
> > > https://git.linaro.org/people/john.stultz/linux.git dev/early-leap-timer
> >
> > Any idea how far back this reaches ? Ie, which longterm stable releases
> > might be affected by this ?
>
> Likely occurs in any kernel after NOHZ was introduced.
At least on 3.14, it seems to happen even if NOHZ is disabled.
# ./leap -i 5 -s
Setting time to speed up testing
Running for 5 iterations. Press ctrl-c to stop
Setting time to Sat Jun 13 23:59:50 2015
Scheduling leap second for Sun Jun 14 00:00:00 2015
Setting timer for Sun Jun 14 00:00:00 2015
Sat Jun 13 23:59:57 2015 + 55 us (1) TIME_INS
Sat Jun 13 23:59:57 2015 + 500127 us (1) TIME_INS
Sat Jun 13 23:59:58 2015 + 189 us (1) TIME_INS
Sat Jun 13 23:59:58 2015 + 500250 us (1) TIME_INS
Sat Jun 13 23:59:59 2015 + 312 us (1) TIME_INS
Sat Jun 13 23:59:59 2015 + 500372 us (1) TIME_INS
Sun Jun 14 00:00:00 2015 + 3 us (1) TIME_INS - TIMER FIRED
Error: Incorrect NTP state?
Sun Jun 14 00:00:00 2015 + 12 us (1) TIME_INS
Sat Jun 13 23:59:59 2015 + 500068 us (2) TIME_OOP
Sun Jun 14 00:00:00 2015 + 130 us (2) TIME_OOP
Sun Jun 14 00:00:00 2015 + 500190 us (2) TIME_WAIT
Sun Jun 14 00:00:01 2015 + 256 us (2) TIME_WAIT
Sun Jun 14 00:00:01 2015 + 500315 us (2) TIME_WAIT
Sun Jun 14 00:00:02 2015 + 376 us (2) TIME_WAIT
Leap complete
Errors observed
Dave
next prev parent reply other threads:[~2015-06-12 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 22:54 John Stultz
2015-06-11 22:54 ` [PATCH 1/5] time: Move clock_was_set_seq update to before we update the shadow-timekeeper John Stultz
2015-06-12 9:31 ` [tip:timers/core] time: Move clock_was_set_seq update before updating shadow-timekeeper tip-bot for John Stultz
2015-06-11 22:54 ` [PATCH 2/5] ntp: Introduce and use SECS_PER_DAY macro instead of 86400 John Stultz
2015-06-12 9:31 ` [tip:timers/core] " tip-bot for John Stultz
2015-06-11 22:54 ` [PATCH 3/5] time: Do leapsecond adjustment to avoid early timer expirations John Stultz
2015-06-12 9:32 ` [tip:timers/core] time: Prevent early expiry of hrtimers[ CLOCK_REALTIME] at the leap second edge tip-bot for John Stultz
2015-06-11 22:54 ` [PATCH 4/5] ntp: Do leapsecond adjustment in adjtimex read path John Stultz
2015-06-12 7:37 ` Richard Cochran
2015-06-12 9:32 ` [tip:timers/core] " tip-bot for John Stultz
2015-06-11 22:54 ` [PATCH 5/5] selftests: timers: Add leap-second timer edge testing to leap-a-day.c John Stultz
2015-06-12 9:32 ` [tip:timers/core] " tip-bot for John Stultz
2015-06-12 14:52 ` [PATCH 0/5 v2] Fixes for leapsecond expiring early ABS_TIME CLOCK_REALTIME timers Dave Jones
2015-06-12 14:55 ` Prarit Bhargava
2015-06-12 14:59 ` Dave Jones [this message]
2015-06-12 15:02 ` Prarit Bhargava
2015-06-12 17:58 ` John Stultz
2015-06-12 18:06 ` John Stultz
2015-06-12 18:11 ` Thomas Gleixner
2015-06-13 7:17 ` Ingo Molnar
2015-06-15 13:10 ` Prarit Bhargava
2015-06-15 13:46 ` Prarit Bhargava
2015-06-15 18:55 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612145958.GB22489@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=bristot@redhat.com \
--cc=jack@suse.cz \
--cc=jbohac@suse.cz \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®