* Re: [PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool_free
[not found] <1436225431-5880-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-07 22:41 ` Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2015-07-07 22:41 UTC (permalink / raw)
To: Nicholas Krause; +Cc: khalasa, bigeasy, paulmcquad, linux-mm, linux-kernel
On Mon, 6 Jul 2015 19:30:31 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes the unlabeled block of code after the if statement that
> executes if the passed dma variable of type dma_addr_t minus the
> structure pointer page's dma member is equal to the variable offset
> into a else block as this block should run when the if statement check
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> mm/dmapool.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/dmapool.c b/mm/dmapool.c
> index fd5fe43..ce7ff4b 100644
> --- a/mm/dmapool.c
> +++ b/mm/dmapool.c
> @@ -434,8 +434,7 @@ void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma)
> "dma_pool_free %s, %p (bad vaddr)/%Lx\n",
> pool->name, vaddr, (unsigned long long)dma);
> return;
> - }
> - {
> + } else {
> unsigned int chain = page->offset;
> while (chain < pool->allocation) {
> if (chain != offset) {
This patch has no effect?
^ permalink raw reply [flat|nested] only message in thread