* [PATCH -mm] parse_integer: add checkpatch.pl notice
@ 2015-07-10 21:17 Alexey Dobriyan
0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2015-07-10 21:17 UTC (permalink / raw)
To: akpm; +Cc: joe, linux-kernel
* remove check for strict_strto*(), they were fully removed long ago,
* add check for simple_strto*(), suggest replacements
sscanf() is a bit icky to suggest because it accepts arbitrary amount
of whitespace before any integer conversion, but assume programmer
knows such twist and don't use sscanf() where real strictness is
required (yes, sure...).
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5498,10 +5498,10 @@ sub process {
"consider using a completion\n" . $herecurr);
}
-# recommend kstrto* over simple_strto* and strict_strto*
- if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
+# simple_strto*() is deprecated
+ if ($line =~ /\b(simple_strto(l|ll|ul|ull))\s*\(/) {
WARN("CONSIDER_KSTRTO",
- "$1 is obsolete, use k$3 instead\n" . $herecurr);
+ "$1 is obsolete, use parse_integer(), kstrto*(), kstrto*_from_user(), sscanf() instead\n" . $herecurr);
}
# check for __initcall(), use device_initcall() explicitly or more appropriate function please
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-10 21:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-10 21:17 [PATCH -mm] parse_integer: add checkpatch.pl notice Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®