From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: a.p.zijlstra@chello.nl, acme@kernel.org, luto@kernel.org,
mingo@redhat.com, eranian@google.com, ak@linux.intel.com,
mark.rutland@arm.com, adrian.hunter@intel.com, jolsa@kernel.org,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample
Date: Sun, 26 Jul 2015 18:31:53 +0200 [thread overview]
Message-ID: <20150726163153.GF24646@krava.brq.redhat.com> (raw)
In-Reply-To: <1437745712-16649-5-git-send-email-kan.liang@intel.com>
On Fri, Jul 24, 2015 at 09:48:30AM -0400, kan.liang@intel.com wrote:
SNIP
> + u64 nr = 0;
>
> if (sid) {
> sample->id = v->id;
> @@ -1010,6 +1012,20 @@ static int deliver_sample_value(struct perf_evlist *evlist,
> return 0;
> }
>
> + if (perf_evsel__is_group_leader(sid->evsel)) {
> + evsel = sid->evsel;
> + SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> + sample->read.group.values[nr].value);
> + evlist__for_each_continue(evlist, evsel) {
> + if ((evsel->leader != sid->evsel) ||
> + (++nr >= sample->read.group.nr))
> + break;
> +
> + SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> + sample->read.group.values[nr].value);
I think this should be in upper layer.. why not do this also
within iter_prepare_normal_entry as for the rest of the calculations
I suggested in my other email
jirka
next prev parent reply other threads:[~2015-07-26 16:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 13:48 [PATCH V2 0/6] Freq/CPU%/CORE_BUSY% support kan.liang
2015-07-24 13:48 ` [PATCH V2 1/6] perf,tools: save cpu max freq in perf header kan.liang
2015-07-26 16:31 ` Jiri Olsa
2015-07-26 16:32 ` Jiri Olsa
2015-07-24 13:48 ` [PATCH V2 2/6] perf,tools: read cpu max freq and msr type from header kan.liang
2015-07-24 13:48 ` [PATCH V2 3/6] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D kan.liang
2015-07-26 16:31 ` Jiri Olsa
2015-07-24 13:48 ` [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample kan.liang
2015-07-26 16:31 ` Jiri Olsa [this message]
2015-07-27 22:24 ` Liang, Kan
2015-07-28 13:55 ` Jiri Olsa
2015-07-24 13:48 ` [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat kan.liang
2015-07-26 16:31 ` Jiri Olsa
2015-07-27 17:19 ` Liang, Kan
2015-07-27 17:27 ` Jiri Olsa
2015-07-27 22:34 ` Liang, Kan
2015-07-28 13:50 ` Jiri Olsa
2015-07-26 16:31 ` Jiri Olsa
2015-07-27 17:11 ` Liang, Kan
2015-07-27 17:16 ` Jiri Olsa
2015-07-24 13:48 ` [PATCH V2 6/6] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio kan.liang
2015-07-26 16:32 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726163153.GF24646@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®