Re: [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat

[Jiri Olsa <jolsa@redhat.com>]

On Mon, Jul 27, 2015 at 05:11:13PM +0000, Liang, Kan wrote:
> > 
> > On Fri, Jul 24, 2015 at 09:48:31AM -0400, kan.liang@intel.com wrote:
> > 
> > SNIP
> > 
> > >  				      struct addr_location *al,
> > > @@ -109,6 +110,7 @@ struct hist_entry *__hists__add_entry(struct
> > hists *hists,
> > >  				      struct branch_info *bi,
> > >  				      struct mem_info *mi, u64 period,
> > >  				      u64 weight, u64 transaction,
> > > +				      struct freq_perf_info *freq_perf,
> > >  				      bool sample_self);
> > >  int hist_entry_iter__add(struct hist_entry_iter *iter, struct
> > addr_location *al,
> > >  			 int max_stack_depth, void *arg);
> > > diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index
> > > e97cd47..90422ed 100644
> > > --- a/tools/perf/util/sort.h
> > > +++ b/tools/perf/util/sort.h
> > > @@ -54,6 +54,9 @@ struct he_stat {
> > >  	u64			period_guest_us;
> > >  	u64			weight;
> > >  	u32			nr_events;
> > > +	u64			freq;
> > > +	u64			cpu_u;
> > 
> > could the cpu_u have more descriptive name?
> 
> How about "cpu_util" or "cpu_utilization"?

cpu_util sounds good to me

thanks,
jirka