Re: [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat

[Jiri Olsa <jolsa@redhat.com>]

On Mon, Jul 27, 2015 at 10:34:04PM +0000, Liang, Kan wrote:
> 
> > 
> > On Fri, Jul 24, 2015 at 09:48:31AM -0400, kan.liang@intel.com wrote:
> > 
> > SNIP
> > 
> > >  		},
> > >  		.parent = sym_parent,
> > >  		.filtered = symbol__parent_filter(sym_parent) | al-
> > >filtered, @@
> > > -481,6 +486,32 @@ iter_add_next_nop_entry(struct hist_entry_iter
> > *iter
> > > __maybe_unused,  }
> > >
> > >  static int
> > > +iter_add_single_freq_perf_entry(struct hist_entry_iter *iter, struct
> > > +addr_location *al) {
> > > +	struct perf_evsel *evsel = iter->evsel;
> > > +	struct perf_sample *sample = iter->sample;
> > > +	struct hist_entry *he;
> > > +	struct freq_perf_info info = {0};
> > > +	u64 *data = sample->freq_perf_data;
> > > +
> > > +	if (data[FREQ_PERF_REF_CYCLES] > 0)
> > > +		info.freq = (data[FREQ_PERF_CYCLES] * cpu_max_freq) /
> > data[FREQ_PERF_REF_CYCLES];
> > > +	if (data[FREQ_PERF_TSC] > 0)
> > > +		info.cpu_u = (100 * data[FREQ_PERF_REF_CYCLES]) /
> > data[FREQ_PERF_TSC];
> > > +	if (data[FREQ_PERF_MPERF] > 0)
> > > +		info.core_busy = (100 * data[FREQ_PERF_APERF]) /
> > > +data[FREQ_PERF_MPERF];
> > 
> > seems to me the new iterator is too big gun for this, why not initialize
> > 'struct freq_perf_info' in iter_prepare_normal_entry ?
> > 
> How about initializing in iter_add_single_normal_entry?
> 
> We only use freq_perf_info in iter_add_single_normal_entry.
> If initializing in iter_prepare_normal_entry, we have to save the
> freq_perf_info in hist_entry_iter.

sounds good

jirka