[PATCH] trace-cmd: annotate function durations like the kernel

[PATCH] trace-cmd: annotate function durations like the kernel

[Omar Sandoval]

Since kernel commit, 8e1e1df29d83 ("tracing: Add additional marks to
signal very large time deltas") the kernel annotates durations longer
than 1000 usecs with # and longer than 1 sec with $. Update trace-cmd
report to be consistent with it.

Signed-off-by: Omar Sandoval <osandov@fb.com>
---
Just a minor cosmetic issue I noticed. Thanks!

 trace-ftrace.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/trace-ftrace.c b/trace-ftrace.c
index bdf11ce4c2dd..636b08b5cdef 100644
--- a/trace-ftrace.c
+++ b/trace-ftrace.c
@@ -147,11 +147,19 @@ static void print_graph_overhead(struct trace_seq *s,
 	if (duration == ~0ULL)
 		return (void)trace_seq_printf(s, "  ");
 
-	/* Duration exceeded 100 msecs */
+	/* Duration exceeded 1 sec */
+	if (duration > 1000000000ULL)
+		return (void)trace_seq_printf(s, "$ ");
+
+	/* Duration exceeded 1000 usecs */
+	if (duration > 1000000ULL)
+		return (void)trace_seq_printf(s, "# ");
+
+	/* Duration exceeded 100 usecs */
 	if (duration > 100000ULL)
 		return (void)trace_seq_printf(s, "! ");
 
-	/* Duration exceeded 10 msecs */
+	/* Duration exceeded 10 usecs */
 	if (duration > 10000ULL)
 		return (void)trace_seq_printf(s, "+ ");
 
-- 
2.4.4

Re: [PATCH] trace-cmd: annotate function durations like the kernel

[Steven Rostedt]

On Wed, 24 Jun 2015 11:36:54 -0700
Omar Sandoval <osandov@fb.com> wrote:

> Since kernel commit, 8e1e1df29d83 ("tracing: Add additional marks to
> signal very large time deltas") the kernel annotates durations longer
> than 1000 usecs with # and longer than 1 sec with $. Update trace-cmd
> report to be consistent with it.


Thanks, applied.

(sorry for the late notice). I'll be pushing this up later today.

-- Steve

> 
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> Just a minor cosmetic issue I noticed. Thanks!
> 
>  trace-ftrace.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/trace-ftrace.c b/trace-ftrace.c
> index bdf11ce4c2dd..636b08b5cdef 100644
> --- a/trace-ftrace.c
> +++ b/trace-ftrace.c
> @@ -147,11 +147,19 @@ static void print_graph_overhead(struct trace_seq *s,
>  	if (duration == ~0ULL)
>  		return (void)trace_seq_printf(s, "  ");
>  
> -	/* Duration exceeded 100 msecs */
> +	/* Duration exceeded 1 sec */
> +	if (duration > 1000000000ULL)
> +		return (void)trace_seq_printf(s, "$ ");
> +
> +	/* Duration exceeded 1000 usecs */
> +	if (duration > 1000000ULL)
> +		return (void)trace_seq_printf(s, "# ");
> +
> +	/* Duration exceeded 100 usecs */
>  	if (duration > 100000ULL)
>  		return (void)trace_seq_printf(s, "! ");
>  
> -	/* Duration exceeded 10 msecs */
> +	/* Duration exceeded 10 usecs */
>  	if (duration > 10000ULL)
>  		return (void)trace_seq_printf(s, "+ ");
>  

Re: [PATCH] trace-cmd: annotate function durations like the kernel

[Omar Sandoval]

On Mon, Jul 13, 2015 at 02:43:19PM -0400, Steven Rostedt wrote:
> On Wed, 24 Jun 2015 11:36:54 -0700
> Omar Sandoval <osandov@fb.com> wrote:
> 
> > Since kernel commit, 8e1e1df29d83 ("tracing: Add additional marks to
> > signal very large time deltas") the kernel annotates durations longer
> > than 1000 usecs with # and longer than 1 sec with $. Update trace-cmd
> > report to be consistent with it.
> 
> 
> Thanks, applied.
> 
> (sorry for the late notice). I'll be pushing this up later today.
> 
> -- Steve

Hey, Steve,

I just built the latest master and noticed that this wasn't included.
Did I miss something or did the patch get abducted by aliens sometime
between this email and git.kernel.org? :)

Thanks!
-- 
Omar

Re: [PATCH] trace-cmd: annotate function durations like the kernel

[Steven Rostedt]

On Wed, 29 Jul 2015 10:20:15 -0700
Omar Sandoval <osandov@fb.com> wrote:

> On Mon, Jul 13, 2015 at 02:43:19PM -0400, Steven Rostedt wrote:
> > On Wed, 24 Jun 2015 11:36:54 -0700
> > Omar Sandoval <osandov@fb.com> wrote:
> > 
> > > Since kernel commit, 8e1e1df29d83 ("tracing: Add additional marks to
> > > signal very large time deltas") the kernel annotates durations longer
> > > than 1000 usecs with # and longer than 1 sec with $. Update trace-cmd
> > > report to be consistent with it.
> > 
> > 
> > Thanks, applied.
> > 
> > (sorry for the late notice). I'll be pushing this up later today.
> > 
> > -- Steve
> 
> Hey, Steve,
> 
> I just built the latest master and noticed that this wasn't included.
> Did I miss something or did the patch get abducted by aliens sometime
> between this email and git.kernel.org? :)
> 
>

I found bugs in the queue I wanted to push out, and since I was going
on vacation, I didn't have time to finish debugging it, and push out
the final result. Your patch is still in that queue.

I wont get to it today, as I'm only on Wednesday in my INBOX (i've been
working on it all day so far).

Sorry for the delay.

-- Steve