From: Mark Brown <broonie@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile
Date: Sat, 1 Aug 2015 11:59:14 +0100 [thread overview]
Message-ID: <20150801105914.GR20873@sirena.org.uk> (raw)
In-Reply-To: <1438371747-8644-1-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote:
> Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
> is enabled. (see drivers/base/Makefile)
>
> $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
> to 'y'.
> -obj-$(CONFIG_REGMAP) += regmap.o regcache.o
> -obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> +obj-y += regmap.o regcache.o
> +obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
> obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
> obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o
OTOH it does make the Makefile look a bit neater to have everything
selected by config option... is there a practical cost here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-08-01 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 19:42 Masahiro Yamada
2015-08-01 10:59 ` Mark Brown [this message]
2015-08-01 12:30 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801105914.GR20873@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®