* [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile
@ 2015-07-31 19:42 Masahiro Yamada
2015-08-01 10:59 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2015-07-31 19:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Masahiro Yamada, Greg Kroah-Hartman, Mark Brown
Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
is enabled. (see drivers/base/Makefile)
$(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
to 'y'.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/base/regmap/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/regmap/Makefile b/drivers/base/regmap/Makefile
index 609e4c8..b1b4041 100644
--- a/drivers/base/regmap/Makefile
+++ b/drivers/base/regmap/Makefile
@@ -1,8 +1,8 @@
# For include/trace/define_trace.h to include trace.h
CFLAGS_regmap.o := -I$(src)
-obj-$(CONFIG_REGMAP) += regmap.o regcache.o
-obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
+obj-y += regmap.o regcache.o
+obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile
2015-07-31 19:42 [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile Masahiro Yamada
@ 2015-08-01 10:59 ` Mark Brown
2015-08-01 12:30 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2015-08-01 10:59 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kernel, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote:
> Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
> is enabled. (see drivers/base/Makefile)
>
> $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
> to 'y'.
> -obj-$(CONFIG_REGMAP) += regmap.o regcache.o
> -obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> +obj-y += regmap.o regcache.o
> +obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
> obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
> obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o
OTOH it does make the Makefile look a bit neater to have everything
selected by config option... is there a practical cost here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile
2015-08-01 10:59 ` Mark Brown
@ 2015-08-01 12:30 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2015-08-01 12:30 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux Kernel Mailing List, Greg Kroah-Hartman
Hi Mark,
2015-08-01 19:59 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote:
>> Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
>> is enabled. (see drivers/base/Makefile)
>>
>> $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
>> to 'y'.
>
>> -obj-$(CONFIG_REGMAP) += regmap.o regcache.o
>> -obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
>> +obj-y += regmap.o regcache.o
>> +obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
>> obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
>> obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
>> obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o
>
> OTOH it does make the Makefile look a bit neater to have everything
> selected by config option... is there a practical cost here?
Almost no cost.
We can save expanding $(CONFIG_REGMAP),
but it is practically unnoticeable.
Please feel free to ignore this patch if you do not like it.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-01 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-31 19:42 [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile Masahiro Yamada
2015-08-01 10:59 ` Mark Brown
2015-08-01 12:30 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®