From: Greg KH <gregkh@linuxfoundation.org>
To: Aparna Karuthodi <kdasaparna@gmail.com>
Cc: chris@the-brannons.com, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, speakup@linux-speakup.org,
samuel.thibault@ens-lyon.org
Subject: Re: [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul
Date: Fri, 11 Sep 2015 19:59:58 -0700 [thread overview]
Message-ID: <20150912025958.GA27284@kroah.com> (raw)
In-Reply-To: <1441974994-7224-1-git-send-email-kdasaparna@gmail.com>
On Fri, Sep 11, 2015 at 06:06:34PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul inorder to fix a warning
> detected by checkpatch.
> The warning is given below:
> drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/speakup/kobjects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 3708bc1..05de0b7 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
> continue;
> }
>
> - index = simple_strtoul(cp, &temp, 10);
> + index = kstrtoul(cp, &temp, 10);
> if (index > 255) {
> rejected++;
> cp = linefeed + 1;
> --
> 1.7.9.5
Never send patches that you yourself did not at least test-build.
prev parent reply other threads:[~2015-09-12 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 12:36 Aparna Karuthodi
2015-09-12 2:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912025958.GA27284@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=kdasaparna@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®