mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul
@ 2015-09-11 12:36 Aparna Karuthodi
  2015-09-12  2:59 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Aparna Karuthodi @ 2015-09-11 12:36 UTC (permalink / raw)
  To: gregkh
  Cc: chris, linux-kernel, devel, speakup, samuel.thibault, Aparna Karuthodi

Used kstrtoul instead of simple_strtoul inorder to fix a warning
detected by checkpatch.
The warning is given below:
drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
obsolete, use kstrtoul instead

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/speakup/kobjects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 3708bc1..05de0b7 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
 			continue;
 		}
 
-		index = simple_strtoul(cp, &temp, 10);
+		index = kstrtoul(cp, &temp, 10);
 		if (index > 255) {
 			rejected++;
 			cp = linefeed + 1;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul
  2015-09-11 12:36 [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul Aparna Karuthodi
@ 2015-09-12  2:59 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-09-12  2:59 UTC (permalink / raw)
  To: Aparna Karuthodi; +Cc: chris, linux-kernel, devel, speakup, samuel.thibault

On Fri, Sep 11, 2015 at 06:06:34PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul inorder to fix a warning
> detected by checkpatch.
> The warning is given below:
> drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/speakup/kobjects.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 3708bc1..05de0b7 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
>  			continue;
>  		}
>  
> -		index = simple_strtoul(cp, &temp, 10);
> +		index = kstrtoul(cp, &temp, 10);
>  		if (index > 255) {
>  			rejected++;
>  			cp = linefeed + 1;
> -- 
> 1.7.9.5

Never send patches that you yourself did not at least test-build.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-12  4:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-11 12:36 [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul Aparna Karuthodi
2015-09-12  2:59 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®