From: Ken Moffat <zarniwhoop@ntlworld.com>
To: Diego Viola <diego.viola@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable
Date: Mon, 14 Sep 2015 01:24:54 +0100 [thread overview]
Message-ID: <20150914002454.GC3008@milliways> (raw)
In-Reply-To: <CA+ToGPEwQSO083E1juq7A8J3FqDp8H0tVT0dVWuB7K+Kepi6Ug@mail.gmail.com>
On Sun, Sep 13, 2015 at 08:06:02PM -0300, Diego Viola wrote:
> Hello,
>
> Can someone please remove this commit from the repo:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/README?id=6609b638353c99c5736e05abd17197f1cb776e0e
>
> I made a huge grammar mistake in my commit message that I can't
> forget, it makes me feel terrible and I can't stop thinking about it.
>
> Please rewrite the history for the README or whatever, but just make
> this commit go away.
>
> It should have been spelled as:
>
> "README: GTK+ is an acronym"
>
> or
>
> "README: GTK+ is an initialism"
>
> But saying "a acronym" is just wrong.
>
> Thanks and sorry about this mistake, English isn't my native language. :-(
>
> Diego
If it is any consolation, almost everybody makes mistakes in commit
messages. I certainly do, but fortunately many of mine will never
be public. As a native English speaker, 'a acronym' is perfectly
understandable (but 'an initialism' is slightly odd). But once it
is committed and made public, it is done.
The content of your change is correct. Thanks for fixing it. In
future, perhaps do what I try to do - for commit messages themselves,
review before the next commit, and if necessary git commit --amend.
For email subjects, try to review before sending (I fail on both of
these).
What's done is done, and the kernel *is* better for your
contribution. It is said that in the early days of the kernel there
was a war between those who could spell and those who could not.
Please, don't worry about grammar - as long as the text can be
understood, there is no problem.
ĸen
--
Il Porcupino Nil Sodomy Est! (if you will excuse my latatian)
aka "The hedgehog song"
next prev parent reply other threads:[~2015-09-14 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 23:06 Diego Viola
2015-09-14 0:24 ` Ken Moffat [this message]
2015-09-14 1:11 ` Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914002454.GC3008@milliways \
--to=zarniwhoop@ntlworld.com \
--cc=diego.viola@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®