mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable
@ 2015-09-13 23:06 Diego Viola
  2015-09-14  0:24 ` Ken Moffat
  0 siblings, 1 reply; 3+ messages in thread
From: Diego Viola @ 2015-09-13 23:06 UTC (permalink / raw)
  To: linux-kernel, trivial

Hello,

Can someone please remove this commit from the repo:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/README?id=6609b638353c99c5736e05abd17197f1cb776e0e

I made a huge grammar mistake in my commit message that I can't
forget, it makes me feel terrible and I can't stop thinking about it.

Please rewrite the history for the README or whatever, but just make
this commit go away.

It should have been spelled as:

"README: GTK+ is an acronym"

or

"README: GTK+ is an initialism"

But saying "a acronym" is just wrong.

Thanks and sorry about this mistake, English isn't my native language. :-(

Diego

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable
  2015-09-13 23:06 Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable Diego Viola
@ 2015-09-14  0:24 ` Ken Moffat
  2015-09-14  1:11   ` Diego Viola
  0 siblings, 1 reply; 3+ messages in thread
From: Ken Moffat @ 2015-09-14  0:24 UTC (permalink / raw)
  To: Diego Viola; +Cc: linux-kernel, trivial

On Sun, Sep 13, 2015 at 08:06:02PM -0300, Diego Viola wrote:
> Hello,
> 
> Can someone please remove this commit from the repo:
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/README?id=6609b638353c99c5736e05abd17197f1cb776e0e
> 
> I made a huge grammar mistake in my commit message that I can't
> forget, it makes me feel terrible and I can't stop thinking about it.
> 
> Please rewrite the history for the README or whatever, but just make
> this commit go away.
> 
> It should have been spelled as:
> 
> "README: GTK+ is an acronym"
> 
> or
> 
> "README: GTK+ is an initialism"
> 
> But saying "a acronym" is just wrong.
> 
> Thanks and sorry about this mistake, English isn't my native language. :-(
> 
> Diego

If it is any consolation, almost everybody makes mistakes in commit
messages.  I certainly do, but fortunately many of mine will never
be public.  As a native English speaker, 'a acronym' is perfectly
understandable (but 'an initialism' is slightly odd).  But once it
is committed and made public, it is done.

The content of your change is correct.  Thanks for fixing it.  In
future, perhaps do what I try to do - for commit messages themselves,
review before the next commit, and if necessary git commit --amend.
For email subjects, try to review before sending (I fail on both of
these).

What's done is done, and the kernel *is* better for your
contribution.  It is said that in the early days of the kernel there
was a war between those who could spell and those who could not.
Please, don't worry about grammar - as long as the text can be
understood, there is no problem.

ĸen
-- 
Il Porcupino Nil Sodomy Est! (if you will excuse my latatian)
  aka "The hedgehog song"


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable
  2015-09-14  0:24 ` Ken Moffat
@ 2015-09-14  1:11   ` Diego Viola
  0 siblings, 0 replies; 3+ messages in thread
From: Diego Viola @ 2015-09-14  1:11 UTC (permalink / raw)
  To: Ken Moffat; +Cc: linux-kernel, trivial

On Sun, Sep 13, 2015 at 9:24 PM, Ken Moffat <zarniwhoop@ntlworld.com> wrote:
> On Sun, Sep 13, 2015 at 08:06:02PM -0300, Diego Viola wrote:
>> Hello,
>>
>> Can someone please remove this commit from the repo:
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/README?id=6609b638353c99c5736e05abd17197f1cb776e0e
>>
>> I made a huge grammar mistake in my commit message that I can't
>> forget, it makes me feel terrible and I can't stop thinking about it.
>>
>> Please rewrite the history for the README or whatever, but just make
>> this commit go away.
>>
>> It should have been spelled as:
>>
>> "README: GTK+ is an acronym"
>>
>> or
>>
>> "README: GTK+ is an initialism"
>>
>> But saying "a acronym" is just wrong.
>>
>> Thanks and sorry about this mistake, English isn't my native language. :-(
>>
>> Diego
>
> If it is any consolation, almost everybody makes mistakes in commit
> messages.  I certainly do, but fortunately many of mine will never
> be public.  As a native English speaker, 'a acronym' is perfectly
> understandable (but 'an initialism' is slightly odd).  But once it
> is committed and made public, it is done.
>
> The content of your change is correct.  Thanks for fixing it.  In
> future, perhaps do what I try to do - for commit messages themselves,
> review before the next commit, and if necessary git commit --amend.
> For email subjects, try to review before sending (I fail on both of
> these).
>
> What's done is done, and the kernel *is* better for your
> contribution.  It is said that in the early days of the kernel there
> was a war between those who could spell and those who could not.
> Please, don't worry about grammar - as long as the text can be
> understood, there is no problem.
>
> ĸen
> --
> Il Porcupino Nil Sodomy Est! (if you will excuse my latatian)
>   aka "The hedgehog song"
>

Thanks, that made me feel better. I'll be more careful next time. :-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-14  1:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-13 23:06 Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable Diego Viola
2015-09-14  0:24 ` Ken Moffat
2015-09-14  1:11   ` Diego Viola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®