From: Mark Brown <broonie@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: gregkh@linuxfoundation.org, sameo@linux.intel.com,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
workgroup.linux@csr.com, Guo Zeng <Guo.Zeng@csr.com>,
Barry Song <Baohua.Song@csr.com>
Subject: Re: [PATCH 1/3] regmap: irq: add support for chips who have separate unmask registers
Date: Wed, 16 Sep 2015 20:37:20 +0100 [thread overview]
Message-ID: <20150916193720.GP12027@sirena.org.uk> (raw)
In-Reply-To: <1442223610-32257-2-git-send-email-21cnbao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
On Mon, Sep 14, 2015 at 09:40:08AM +0000, Barry Song wrote:
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -800,12 +800,15 @@ struct regmap_irq {
> *
> * @status_base: Base status register address.
> * @mask_base: Base mask register address.
> + * @unmask_base: Base unmask register address. for chips who have
> + * separate mask and unmask registers
> * @ack_base: Base ack address. If zero then the chip is clear on read.
> * Using zero value is possible with @use_ack bit.
> * @wake_base: Base address for wake enables. If zero unsupported.
> * @irq_reg_stride: Stride to use for chips where registers are not contiguous.
> * @init_ack_masked: Ack all masked interrupts once during initalization.
> * @mask_invert: Inverted mask register: cleared bits are masked out.
> + * @unmask_separate: unmask is separate register from mask.
We shouldn't need this - we should just be able to check if there's an
unmask_base set and use that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-16 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 9:40 [PATCH 0/3] add CSR SiRFSoC power control module MFD driver Barry Song
2015-09-14 9:40 ` [PATCH 1/3] regmap: irq: add support for chips who have separate unmask registers Barry Song
2015-09-16 19:37 ` Mark Brown [this message]
2015-09-14 9:40 ` [PATCH 2/3] regmap: irq: add ack_invert flag for chips using cleared bits as ack Barry Song
2015-09-16 19:39 ` Mark Brown
2015-09-14 9:40 ` [PATCH 3/3] mfd: add CSR SiRFSoC on-chip power management module driver Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916193720.GP12027@sirena.org.uk \
--to=broonie@kernel.org \
--cc=21cnbao@gmail.com \
--cc=Baohua.Song@csr.com \
--cc=Guo.Zeng@csr.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®