[PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver

[PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver

[Luis de Bethencourt]

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

Link: https://lkml.org/lkml/2015/7/30/519
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

This fixes the typo error of version 2 reported by Stephen Rothwell
https://lkml.org/lkml/2015/9/17/1

 drivers/ata/pata_macio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index b002858..e3d4b05 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] =
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, pata_macio_match);
 
 static struct macio_driver pata_macio_driver =
 {
-- 
2.4.6

Re: [PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver

[Luis de Bethencourt]

On Thu, Sep 17, 2015 at 01:19:45PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> Link: https://lkml.org/lkml/2015/7/30/519
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> This fixes the typo error of version 2 reported by Stephen Rothwell
> https://lkml.org/lkml/2015/9/17/1
> 
>  drivers/ata/pata_macio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index b002858..e3d4b05 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] =
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, pata_macio_match);
>  
>  static struct macio_driver pata_macio_driver =
>  {
> -- 
> 2.4.6
> 

Hi Tejun,

I sent this patch thinking that you would like to git revert the applied one
and git apply a correct one. To keep git bisect-ability.

You might want to apply a delta patch though. I could send that one, as you
prefer.

Thanks,
Luis

Re: [PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver

[Tejun Heo]

On Thu, Sep 17, 2015 at 01:19:45PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> Link: https://lkml.org/lkml/2015/7/30/519
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Replaced the original patch with this one.  We all make mistakes but
please make sure that at least the minimum amount of verification is
done before submitting patches.

Thanks.

-- 
tejun

Re: [PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver

[Luis de Bethencourt]

On Thu, Sep 17, 2015 at 11:16:17AM -0400, Tejun Heo wrote:
> On Thu, Sep 17, 2015 at 01:19:45PM +0200, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> > 
> > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> > that information so modules have the correct aliases built-in and
> > autoloading works correctly.
> > 
> > Link: https://lkml.org/lkml/2015/7/30/519
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> 
> Replaced the original patch with this one.  We all make mistakes but
> please make sure that at least the minimum amount of verification is
> done before submitting patches.
> 
> Thanks.
> 
> -- 
> tejun

Thank you Tejun, for replacing the patch and your patience.

Apologies again for the mistake.
Luis