* tools/build: fixdep versus tools/lib/bpf @ 2015-10-28 16:30 Arnaldo Carvalho de Melo 2015-10-28 20:13 ` Jiri Olsa 0 siblings, 1 reply; 7+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-10-28 16:30 UTC (permalink / raw) To: Jiri Olsa; +Cc: Wang Nan, Linux Kernel Mailing List Hi Jiri, Wang, I'm getting these while doing 'make -C tools/perf build-test': LD fixdep-in.o LINK fixdep /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied make[6]: *** [bpf.o] Error 1 make[5]: *** [libbpf-in.o] Error 2 make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 make[4]: *** Waiting for unfinished jobs.... It happens at different tests, i.e. seems like a race somewhere in the build system, can you take a look? It happens with my perf/ebpf branch. - Arnaldo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tools/build: fixdep versus tools/lib/bpf 2015-10-28 16:30 tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo @ 2015-10-28 20:13 ` Jiri Olsa 2015-10-28 20:37 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 7+ messages in thread From: Jiri Olsa @ 2015-10-28 20:13 UTC (permalink / raw) To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, Wang Nan, Linux Kernel Mailing List On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote: > Hi Jiri, Wang, > > I'm getting these while doing 'make -C tools/perf build-test': > > LD fixdep-in.o > LINK fixdep > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied > make[6]: *** [bpf.o] Error 1 > make[5]: *** [libbpf-in.o] Error 2 > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 > make[4]: *** Waiting for unfinished jobs.... > > > It happens at different tests, i.e. seems like a race somewhere in the > build system, can you take a look? It happens with my perf/ebpf branch. could not reproduce, but looks like attached patch should help jirka --- diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 1e2e2d1d26b7..0d19d5447d6c 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -430,7 +430,7 @@ $(LIBAPI)-clean: $(call QUIET_CLEAN, libapi) $(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null -$(LIBBPF): FORCE +$(LIBBPF): fixdep FORCE $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a $(LIBBPF)-clean: ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tools/build: fixdep versus tools/lib/bpf 2015-10-28 20:13 ` Jiri Olsa @ 2015-10-28 20:37 ` Arnaldo Carvalho de Melo 2015-10-28 20:44 ` Jiri Olsa 0 siblings, 1 reply; 7+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-10-28 20:37 UTC (permalink / raw) To: Jiri Olsa; +Cc: Jiri Olsa, Wang Nan, Linux Kernel Mailing List Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu: > On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote: > > Hi Jiri, Wang, > > > > I'm getting these while doing 'make -C tools/perf build-test': > > > > LD fixdep-in.o > > LINK fixdep > > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied > > make[6]: *** [bpf.o] Error 1 > > make[5]: *** [libbpf-in.o] Error 2 > > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 > > make[4]: *** Waiting for unfinished jobs.... > > > > > > It happens at different tests, i.e. seems like a race somewhere in the > > build system, can you take a look? It happens with my perf/ebpf branch. > > could not reproduce, but looks like attached patch should help I'll test this now, i.e. make it go thru a 'make -C tools/perf build-test'. In the interest of speeding up things, please provide an explanation of why this should be applied, so that I can add it to the changeset log. Thanks a bunch! - Arnaldo > jirka > > > --- > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 1e2e2d1d26b7..0d19d5447d6c 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -430,7 +430,7 @@ $(LIBAPI)-clean: > $(call QUIET_CLEAN, libapi) > $(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null > > -$(LIBBPF): FORCE > +$(LIBBPF): fixdep FORCE > $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a > > $(LIBBPF)-clean: ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tools/build: fixdep versus tools/lib/bpf 2015-10-28 20:37 ` Arnaldo Carvalho de Melo @ 2015-10-28 20:44 ` Jiri Olsa 2015-10-28 21:01 ` Arnaldo Carvalho de Melo 2015-10-30 9:13 ` [tip:perf/core] perf tools: Make sure fixdep is built before libbpf tip-bot for Jiri Olsa 0 siblings, 2 replies; 7+ messages in thread From: Jiri Olsa @ 2015-10-28 20:44 UTC (permalink / raw) To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, Wang Nan, Linux Kernel Mailing List On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > Hi Jiri, Wang, > > > > > > I'm getting these while doing 'make -C tools/perf build-test': > > > > > > LD fixdep-in.o > > > LINK fixdep > > > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied > > > make[6]: *** [bpf.o] Error 1 > > > make[5]: *** [libbpf-in.o] Error 2 > > > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 > > > make[4]: *** Waiting for unfinished jobs.... > > > > > > > > > It happens at different tests, i.e. seems like a race somewhere in the > > > build system, can you take a look? It happens with my perf/ebpf branch. > > > > could not reproduce, but looks like attached patch should help > > I'll test this now, i.e. make it go thru a 'make -C tools/perf > build-test'. > > In the interest of speeding up things, please provide an explanation of > why this should be applied, so that I can add it to the changeset log. > > Thanks a bunch! > The fixdep tool needs to be built as the first binary. Libraries are built in paralel, so each of them needs to depend on fixdep target. jirka > > jirka > > > > > > --- > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > index 1e2e2d1d26b7..0d19d5447d6c 100644 > > --- a/tools/perf/Makefile.perf > > +++ b/tools/perf/Makefile.perf > > @@ -430,7 +430,7 @@ $(LIBAPI)-clean: > > $(call QUIET_CLEAN, libapi) > > $(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null > > > > -$(LIBBPF): FORCE > > +$(LIBBPF): fixdep FORCE > > $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a > > > > $(LIBBPF)-clean: ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tools/build: fixdep versus tools/lib/bpf 2015-10-28 20:44 ` Jiri Olsa @ 2015-10-28 21:01 ` Arnaldo Carvalho de Melo 2015-10-29 2:39 ` Wangnan (F) 2015-10-30 9:13 ` [tip:perf/core] perf tools: Make sure fixdep is built before libbpf tip-bot for Jiri Olsa 1 sibling, 1 reply; 7+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-10-28 21:01 UTC (permalink / raw) To: Jiri Olsa; +Cc: Jiri Olsa, Wang Nan, Linux Kernel Mailing List Em Wed, Oct 28, 2015 at 09:44:50PM +0100, Jiri Olsa escreveu: > On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu: > > > On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Hi Jiri, Wang, > > > > > > > > I'm getting these while doing 'make -C tools/perf build-test': > > > > > > > > LD fixdep-in.o > > > > LINK fixdep > > > > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied > > > > make[6]: *** [bpf.o] Error 1 > > > > make[5]: *** [libbpf-in.o] Error 2 > > > > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 > > > > make[4]: *** Waiting for unfinished jobs.... > > > > > > > > > > > > It happens at different tests, i.e. seems like a race somewhere in the > > > > build system, can you take a look? It happens with my perf/ebpf branch. > > > > > > could not reproduce, but looks like attached patch should help > > > > I'll test this now, i.e. make it go thru a 'make -C tools/perf > > build-test'. > > > > In the interest of speeding up things, please provide an explanation of > > why this should be applied, so that I can add it to the changeset log. > > > > Thanks a bunch! > > > > The fixdep tool needs to be built as the first binary. > Libraries are built in paralel, so each of them needs > to depend on fixdep target. I really need a faster machine, you provided the answer at this point: - make_tags_O: cd . && make -f Makefile O=/tmp/tmp.xfRz6THR6o DESTDIR=/tmp/tmp.y0nuN0Fr9n tags - make_cscope_O: cd . && make -f Makefile O=/tmp/tmp.O6phQXHU4z DESTDIR=/tmp/tmp.5mdMeF1pH2 cscope - tarpkg: ./tests/perf-targz-src-pkg . - make -C <kernelsrc> tools/perf - make -C <kernelsrc>/tools perf Almost there :-) - Arnaldo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tools/build: fixdep versus tools/lib/bpf 2015-10-28 21:01 ` Arnaldo Carvalho de Melo @ 2015-10-29 2:39 ` Wangnan (F) 0 siblings, 0 replies; 7+ messages in thread From: Wangnan (F) @ 2015-10-29 2:39 UTC (permalink / raw) To: Arnaldo Carvalho de Melo, Jiri Olsa; +Cc: Jiri Olsa, Linux Kernel Mailing List On 2015/10/29 5:01, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 28, 2015 at 09:44:50PM +0100, Jiri Olsa escreveu: >> On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote: >>> Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu: >>>> On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote: >>>>> Hi Jiri, Wang, >>>>> >>>>> I'm getting these while doing 'make -C tools/perf build-test': >>>>> >>>>> LD fixdep-in.o >>>>> LINK fixdep >>>>> /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied >>>>> make[6]: *** [bpf.o] Error 1 >>>>> make[5]: *** [libbpf-in.o] Error 2 >>>>> make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 >>>>> make[4]: *** Waiting for unfinished jobs.... >>>>> >>>>> >>>>> It happens at different tests, i.e. seems like a race somewhere in the >>>>> build system, can you take a look? It happens with my perf/ebpf branch. Never see this message before. Tried make build-test, unable to reproduce in my environment. Maybe my machine is not fast enough? >>>> could not reproduce, but looks like attached patch should help >>> I'll test this now, i.e. make it go thru a 'make -C tools/perf >>> build-test'. >>> >>> In the interest of speeding up things, please provide an explanation of >>> why this should be applied, so that I can add it to the changeset log. >>> >>> Thanks a bunch! >>> >> The fixdep tool needs to be built as the first binary. >> Libraries are built in paralel, so each of them needs >> to depend on fixdep target. > > I really need a faster machine, you provided the answer at this point: > > - make_tags_O: cd . && make -f Makefile O=/tmp/tmp.xfRz6THR6o > DESTDIR=/tmp/tmp.y0nuN0Fr9n tags > - make_cscope_O: cd . && make -f Makefile O=/tmp/tmp.O6phQXHU4z > DESTDIR=/tmp/tmp.5mdMeF1pH2 cscope > - tarpkg: ./tests/perf-targz-src-pkg . > - make -C <kernelsrc> tools/perf > - make -C <kernelsrc>/tools perf > > Almost there :-) So the problem is gone? Thanks to Jiri, and I'll add this to my local tree, as a separated patch first. Thank you. > - Arnaldo ^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:perf/core] perf tools: Make sure fixdep is built before libbpf 2015-10-28 20:44 ` Jiri Olsa 2015-10-28 21:01 ` Arnaldo Carvalho de Melo @ 2015-10-30 9:13 ` tip-bot for Jiri Olsa 1 sibling, 0 replies; 7+ messages in thread From: tip-bot for Jiri Olsa @ 2015-10-30 9:13 UTC (permalink / raw) To: linux-tip-commits; +Cc: mingo, acme, jolsa, linux-kernel, tglx, wangnan0, hpa Commit-ID: 50f1e6d0431d3343cb506037c43ce623bd15581f Gitweb: http://git.kernel.org/tip/50f1e6d0431d3343cb506037c43ce623bd15581f Author: Jiri Olsa <jolsa@redhat.com> AuthorDate: Wed, 28 Oct 2015 21:44:50 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 29 Oct 2015 17:16:21 -0300 perf tools: Make sure fixdep is built before libbpf While doing 'make -C tools/perf build-test': LD fixdep-in.o LINK fixdep /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied make[6]: *** [bpf.o] Error 1 make[5]: *** [libbpf-in.o] Error 2 make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2 make[4]: *** Waiting for unfinished jobs.... The fixdep tool needs to be built as the first binary. Libraries are built in paralel, so each of them needs to depend on fixdep target. Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/r/20151028204450.GA25553@krava.redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 1e2e2d1..0d19d54 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -430,7 +430,7 @@ $(LIBAPI)-clean: $(call QUIET_CLEAN, libapi) $(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null -$(LIBBPF): FORCE +$(LIBBPF): fixdep FORCE $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a $(LIBBPF)-clean: ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-30 9:13 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-10-28 16:30 tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo 2015-10-28 20:13 ` Jiri Olsa 2015-10-28 20:37 ` Arnaldo Carvalho de Melo 2015-10-28 20:44 ` Jiri Olsa 2015-10-28 21:01 ` Arnaldo Carvalho de Melo 2015-10-29 2:39 ` Wangnan (F) 2015-10-30 9:13 ` [tip:perf/core] perf tools: Make sure fixdep is built before libbpf tip-bot for Jiri Olsa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome