mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] hwmon/applesmc: Fix uninitialized variables warnings
@ 2015-11-05 22:39 Shuah Khan
  2015-11-06  0:45 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2015-11-05 22:39 UTC (permalink / raw)
  To: rydberg, jdelvare, linux; +Cc: Shuah Khan, lm-sensors, linux-kernel

Fix the following "maybe used uninitialized" warnings by
initializing the variables to keep the compiler quiet.
There is no "used uninitialized" in this case.

  CC [M]  drivers/hwmon/applesmc.o
drivers/hwmon/applesmc.c: In function ‘applesmc_init_smcreg’:
drivers/hwmon/applesmc.c:595:43: warning: ‘right_light_sensor’
may be used uninitialized in this function [-Wmaybe-uninitialized]
  s->num_light_sensors = left_light_sensor + right_light_sensor;
                                           ^
drivers/hwmon/applesmc.c:540:26: note: ‘right_light_sensor’ was
declared here
  bool left_light_sensor, right_light_sensor;
                          ^
drivers/hwmon/applesmc.c:595:43: warning: ‘left_light_sensor’ may
be used uninitialized in this function [-Wmaybe-uninitialized]
  s->num_light_sensors = left_light_sensor + right_light_sensor;
                                           ^
drivers/hwmon/applesmc.c:540:7: note: ‘left_light_sensor’ was
declared here
  bool left_light_sensor, right_light_sensor;
       ^

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 drivers/hwmon/applesmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
index 0af63da..a0d1fd4 100644
--- a/drivers/hwmon/applesmc.c
+++ b/drivers/hwmon/applesmc.c
@@ -537,7 +537,7 @@ static int applesmc_init_index(struct applesmc_registers *s)
 static int applesmc_init_smcreg_try(void)
 {
 	struct applesmc_registers *s = &smcreg;
-	bool left_light_sensor, right_light_sensor;
+	bool left_light_sensor = 0, right_light_sensor = 0;
 	unsigned int count;
 	u8 tmp[1];
 	int ret;
-- 
2.5.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwmon/applesmc: Fix uninitialized variables warnings
  2015-11-05 22:39 [PATCH] hwmon/applesmc: Fix uninitialized variables warnings Shuah Khan
@ 2015-11-06  0:45 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-11-06  0:45 UTC (permalink / raw)
  To: Shuah Khan; +Cc: rydberg, jdelvare, lm-sensors, linux-kernel

On Thu, Nov 05, 2015 at 03:39:27PM -0700, Shuah Khan wrote:
> Fix the following "maybe used uninitialized" warnings by
> initializing the variables to keep the compiler quiet.
> There is no "used uninitialized" in this case.
> 
>   CC [M]  drivers/hwmon/applesmc.o
> drivers/hwmon/applesmc.c: In function ‘applesmc_init_smcreg’:
> drivers/hwmon/applesmc.c:595:43: warning: ‘right_light_sensor’
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>   s->num_light_sensors = left_light_sensor + right_light_sensor;
>                                            ^
> drivers/hwmon/applesmc.c:540:26: note: ‘right_light_sensor’ was
> declared here
>   bool left_light_sensor, right_light_sensor;
>                           ^
> drivers/hwmon/applesmc.c:595:43: warning: ‘left_light_sensor’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>   s->num_light_sensors = left_light_sensor + right_light_sensor;
>                                            ^
> drivers/hwmon/applesmc.c:540:7: note: ‘left_light_sensor’ was
> declared here
>   bool left_light_sensor, right_light_sensor;
>        ^
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-06  0:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-05 22:39 [PATCH] hwmon/applesmc: Fix uninitialized variables warnings Shuah Khan
2015-11-06  0:45 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®