From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: "open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<rtc-linux@googlegroups.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data
Date: Tue, 22 Dec 2015 19:54:14 +0100 [thread overview]
Message-ID: <20151222185414.GB8623@piout.net> (raw)
In-Reply-To: <1449734133-29235-1-git-send-email-a.hajda@samsung.com>
On 10/12/2015 at 08:55:33 +0100, Andrzej Hajda wrote :
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/rtc/rtc-rv8803.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-22 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 7:55 Andrzej Hajda
2015-12-22 18:54 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222185414.GB8623@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.hajda@samsung.com \
--cc=a.zummo@towertech.it \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®