* [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data
@ 2015-12-10 7:55 Andrzej Hajda
2015-12-22 18:54 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2015-12-10 7:55 UTC (permalink / raw)
To: open list:REAL TIME CLOCK (RTC) SUBSYSTEM
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Alessandro Zummo, Alexandre Belloni, open list
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/rtc/rtc-rv8803.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c
index e7329e2..f883aa2 100644
--- a/drivers/rtc/rtc-rv8803.c
+++ b/drivers/rtc/rtc-rv8803.c
@@ -61,7 +61,7 @@ static irqreturn_t rv8803_handle_irq(int irq, void *dev_id)
struct i2c_client *client = dev_id;
struct rv8803_data *rv8803 = i2c_get_clientdata(client);
unsigned long events = 0;
- u8 flags;
+ int flags;
spin_lock(&rv8803->flags_lock);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data
2015-12-10 7:55 [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data Andrzej Hajda
@ 2015-12-22 18:54 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2015-12-22 18:54 UTC (permalink / raw)
To: Andrzej Hajda
Cc: open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
Bartlomiej Zolnierkiewicz, Marek Szyprowski, Alessandro Zummo,
open list
On 10/12/2015 at 08:55:33 +0100, Andrzej Hajda wrote :
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/rtc/rtc-rv8803.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-22 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 7:55 [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data Andrzej Hajda
2015-12-22 18:54 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®