From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/5] perf tools: Add all matching dynamic sort keys for field name
Date: Tue, 5 Jan 2016 10:24:27 +0100 [thread overview]
Message-ID: <20160105092427.GA21867@krava.brq.redhat.com> (raw)
In-Reply-To: <1451963027-16973-2-git-send-email-namhyung@kernel.org>
On Tue, Jan 05, 2016 at 12:03:44PM +0900, Namhyung Kim wrote:
SNIP
> static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> {
> char *str, *event_name, *field_name, *opt_name;
> @@ -1995,7 +2017,12 @@ static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> }
>
> if (!strcmp(field_name, "trace_fields")) {
> - ret = add_all_dynamic_fields(evlist ,raw_trace);
> + ret = add_all_dynamic_fields(evlist, raw_trace);
> + goto out;
> + }
> +
> + if (event_name == NULL) {
> + ret = add_all_matching_fields(evlist, field_name, raw_trace);
> goto out;
should this be handled within find_evsel function:
/* case 1 */
if (event_name == NULL) {
if (evlist->nr_entries != 1) {
looks like it'd be dead code otherwise
thanks,
jirka
next prev parent reply other threads:[~2016-01-05 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 3:03 [PATCH 1/5] perf tools: Fix segfault when using -s trace_fields Namhyung Kim
2016-01-05 3:03 ` [PATCH 2/5] perf tools: Add all matching dynamic sort keys for field name Namhyung Kim
2016-01-05 9:24 ` Jiri Olsa [this message]
2016-01-05 10:46 ` Namhyung Kim
2016-01-05 3:03 ` [PATCH 3/5] perf tools: Add document for dynamic sort keys Namhyung Kim
2016-01-05 9:26 ` Jiri Olsa
2016-01-05 3:03 ` [PATCH 4/5] perf tools: Support dynamic sort keys for -F/--fields Namhyung Kim
2016-01-05 9:30 ` Jiri Olsa
2016-01-05 3:03 ` [PATCH 5/5] perf evlist: Add -T/--trace option to show trace fields Namhyung Kim
2016-01-05 9:32 ` Jiri Olsa
2016-01-05 9:16 ` [PATCH 1/5] perf tools: Fix segfault when using -s trace_fields Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105092427.GA21867@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome