Re: [PATCH 2/5] perf tools: Add all matching dynamic sort keys for field name

[Namhyung Kim <namhyung@kernel.org>]

Hi Jiri,

Thanks for your review!

On Tue, Jan 05, 2016 at 10:24:27AM +0100, Jiri Olsa wrote:
> On Tue, Jan 05, 2016 at 12:03:44PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> >  static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> >  {
> >  	char *str, *event_name, *field_name, *opt_name;
> > @@ -1995,7 +2017,12 @@ static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> >  	}
> >  
> >  	if (!strcmp(field_name, "trace_fields")) {
> > -		ret = add_all_dynamic_fields(evlist ,raw_trace);
> > +		ret = add_all_dynamic_fields(evlist, raw_trace);
> > +		goto out;
> > +	}
> > +
> > +	if (event_name == NULL) {
> > +		ret = add_all_matching_fields(evlist, field_name, raw_trace);
> >  		goto out;
> 
> should this be handled within find_evsel function:
> 
>         /* case 1 */
>         if (event_name == NULL) {
>                 if (evlist->nr_entries != 1) {
> 
> 
> looks like it'd be dead code otherwise

Hmm.. OK.  But the find_evsel() is to get a evsel so it's not good
place to add the code IMHO.  I'll remove the case 1 from it.

Thanks,
Namhyung