From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: [PATCH 1/5] perf tools: Fix segfault when using -s trace_fields
Date: Tue, 5 Jan 2016 12:03:43 +0900 [thread overview]
Message-ID: <1451963027-16973-1-git-send-email-namhyung@kernel.org> (raw)
When the 'trace_fields' sort key is used explicitly for non-tracepoint
events, it'll get segfault since it assumed evsel->tp_format was set.
Skip those events in add_all_dynamic_fields().
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/sort.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index e558e87cafaf..59c4c8586d79 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1955,6 +1955,9 @@ static int add_all_dynamic_fields(struct perf_evlist *evlist, bool raw_trace)
struct perf_evsel *evsel;
evlist__for_each(evlist, evsel) {
+ if (evsel->attr.type != PERF_TYPE_TRACEPOINT)
+ continue;
+
ret = add_evsel_fields(evsel, raw_trace);
if (ret < 0)
return ret;
--
2.6.4
next reply other threads:[~2016-01-05 3:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 3:03 Namhyung Kim [this message]
2016-01-05 3:03 ` [PATCH 2/5] perf tools: Add all matching dynamic sort keys for field name Namhyung Kim
2016-01-05 9:24 ` Jiri Olsa
2016-01-05 10:46 ` Namhyung Kim
2016-01-05 3:03 ` [PATCH 3/5] perf tools: Add document for dynamic sort keys Namhyung Kim
2016-01-05 9:26 ` Jiri Olsa
2016-01-05 3:03 ` [PATCH 4/5] perf tools: Support dynamic sort keys for -F/--fields Namhyung Kim
2016-01-05 9:30 ` Jiri Olsa
2016-01-05 3:03 ` [PATCH 5/5] perf evlist: Add -T/--trace option to show trace fields Namhyung Kim
2016-01-05 9:32 ` Jiri Olsa
2016-01-05 9:16 ` [PATCH 1/5] perf tools: Fix segfault when using -s trace_fields Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451963027-16973-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®