mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
	Jeff Moyer <jmoyer@redhat.com>, Jan Kara <jack@suse.com>
Subject: Re: [PATCH 1/5] cfq-iosched: Don't group_idle if cfqq has big thinktime
Date: Fri, 8 Jan 2016 11:58:31 -0500	[thread overview]
Message-ID: <20160108165831.GU1898@mtj.duckdns.org> (raw)
In-Reply-To: <1452180496-18483-2-git-send-email-jack@suse.cz>

Hello, Jan.

On Thu, Jan 07, 2016 at 04:28:12PM +0100, Jan Kara wrote:
> @@ -2947,8 +2948,13 @@ static void cfq_arm_slice_timer(struct cfq_data *cfqd)
>  		return;
>  	}
>  
> -	/* There are other queues in the group, don't do group idle */
> -	if (group_idle && cfqq->cfqg->nr_cfqq > 1)
> +	/*
> +	 * There are other queues in the group or this is the only group and
> +	 * it has too big thinktime, don't do group idle.
> +	 */
> +	if (group_idle &&
> +	    (cfqq->cfqg->nr_cfqq > 1 ||
> +	     !cfq_io_thinktime_big(cfqd, &st->ttime, true)))
>  		return;

Is the negation in front of the cfq_io_thinktime_big() right?  That
doesn't seem to match the comment or description.  What am I missing?

Thanks.

-- 
tejun

  reply	other threads:[~2016-01-08 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 15:28 [PATCH 0/5 v2] SYNC_NOIDLE preemption for ancestor cgroups Jan Kara
2016-01-07 15:28 ` [PATCH 1/5] cfq-iosched: Don't group_idle if cfqq has big thinktime Jan Kara
2016-01-08 16:58   ` Tejun Heo [this message]
2016-01-11 15:40     ` Jan Kara
2016-01-07 15:28 ` [PATCH 2/5] cfq-iosched: Reorder checks in cfq_should_preempt() Jan Kara
2016-01-08 16:59   ` Tejun Heo
2016-01-07 15:28 ` [PATCH 3/5] cfq-iosched: Allow sync noidle workloads to preempt each other Jan Kara
2016-01-08 18:13   ` Tejun Heo
2016-01-07 15:28 ` [PATCH 4/5] cgroup: Export cgroup_is_descendant() Jan Kara
2016-01-08 18:15   ` Tejun Heo
2016-01-07 15:28 ` [PATCH 5/5] cfq-iosched: Allow parent cgroup to preempt its child Jan Kara
2016-01-08 18:17   ` Tejun Heo
2016-01-12 15:24 [PATCH 0/5 v3] SYNC_NOIDLE preemption for ancestor cgroups Jan Kara
2016-01-12 15:24 ` [PATCH 1/5] cfq-iosched: Don't group_idle if cfqq has big thinktime Jan Kara
2016-01-12 16:17   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160108165831.GU1898@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome