* [PATCH] btrfs: fix ifnullfree.cocci warnings [not found] <201602171939.Xe24Ni6m%fengguang.wu@intel.com> @ 2016-02-17 11:04 ` kbuild test robot 2016-02-18 9:14 ` David Sterba 0 siblings, 1 reply; 2+ messages in thread From: kbuild test robot @ 2016-02-17 11:04 UTC (permalink / raw) To: Anand Jain Cc: kbuild-all, David Sterba, Chris Mason <chris.mason@fusionio.com> Chris Mason, Josef Bacik, linux-btrfs, linux-kernel fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Anand Jain <anand.jain@oracle.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- volumes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1882,8 +1882,7 @@ int btrfs_rm_device(struct btrfs_root *r } out: - if (dev_name) - kfree(dev_name); + kfree(dev_name); mutex_unlock(&uuid_mutex); return ret; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: fix ifnullfree.cocci warnings 2016-02-17 11:04 ` [PATCH] btrfs: fix ifnullfree.cocci warnings kbuild test robot @ 2016-02-18 9:14 ` David Sterba 0 siblings, 0 replies; 2+ messages in thread From: David Sterba @ 2016-02-18 9:14 UTC (permalink / raw) To: kbuild test robot Cc: Anand Jain, kbuild-all, Chris Mason <chris.mason@fusionio.com> Chris Mason, Josef Bacik, linux-btrfs, linux-kernel On Wed, Feb 17, 2016 at 07:04:41PM +0800, kbuild test robot wrote: > fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Anand Jain <anand.jain@oracle.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Thanks, applied to the respective branch. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-18 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201602171939.Xe24Ni6m%fengguang.wu@intel.com>
2016-02-17 11:04 ` [PATCH] btrfs: fix ifnullfree.cocci warnings kbuild test robot
2016-02-18 9:14 ` David Sterba
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®