From: Tejun Heo <tj@kernel.org>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org,
Yang Dongsheng <yangds.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v2 1/2] cpuacct: rename parameter in cpuusage_write for readability
Date: Fri, 11 Mar 2016 12:42:58 -0500 [thread overview]
Message-ID: <20160311174258.GI24046@htj.duckdns.org> (raw)
In-Reply-To: <874fad2881cb09366a618093a05141847ad9a9fa.1457082730.git.zhaolei@cn.fujitsu.com>
On Fri, Mar 04, 2016 at 05:47:05PM +0800, Zhao Lei wrote:
> From: Yang Dongsheng <yangds.fnst@cn.fujitsu.com>
>
> The name of 'reset' makes a little confusion in reading, we would
> say, if we want to reset usage, return -EINVAL. That's not true.
>
> Actually, we want to say, we only allow user to do a reset. This
> patch rename reset to val and add a comment here, making the code
> more readable.
>
> From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2016-03-11 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 9:47 [PATCH v2 0/2] " Zhao Lei
2016-03-04 9:47 ` [PATCH v2 1/2] " Zhao Lei
2016-03-11 17:42 ` Tejun Heo [this message]
2016-03-04 9:47 ` [PATCH v2 2/2] cpuacct: split usage into user_usage and sys_usage Zhao Lei
2016-03-10 13:27 ` Peter Zijlstra
2016-03-16 10:39 ` Zhao Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311174258.GI24046@htj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yangds.fnst@cn.fujitsu.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®