From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
torvalds@linux-foundation.org, hpa@zytor.com, dyoung@redhat.com,
tglx@linutronix.de, luto@kernel.org, peterz@infradead.org,
dvlasenk@redhat.com, linux-kernel@vger.kernel.org,
brgerst@gmail.com, luto@amacapital.net,
akpm@linux-foundation.org, bhe@redhat.com, yinghai@kernel.org,
vgoyal@redhat.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/boot] x86/boot: Clean up pointer casting
Date: Fri, 6 May 2016 12:44:38 +0200 [thread overview]
Message-ID: <20160506104438.GF24044@pd.tnic> (raw)
In-Reply-To: <20160506103619.GA8998@gmail.com>
On Fri, May 06, 2016 at 12:36:19PM +0200, Ingo Molnar wrote:
>
> Hm, your patch throws a lot of warnings during allnoconfig builds:
>
> In file included from arch/x86/boot/compressed/error.c:6:0:
> arch/x86/boot/compressed/misc.h: In function ‘choose_random_location’:
> arch/x86/boot/compressed/misc.h:83:9: warning: return makes pointer from integer
> without a cast [-Wint-conversion]
> return output_ptr;
> ^
Blergh, that's when choose_random_location() is a stub and it needs to
do
return (unsigned char *)output_ptr;
too.
Lemme run all the *config builds on the fixed version before I send you
a v2.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-05-06 10:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 22:13 [PATCH v6 0/11] x86/KASLR: Randomize virtual address separately Kees Cook
2016-05-05 22:13 ` [PATCH v6 01/11] x86/boot: Clean up pointer casting Kees Cook
2016-05-06 7:45 ` [tip:x86/boot] " tip-bot for Kees Cook
2016-05-06 8:53 ` Borislav Petkov
2016-05-06 10:10 ` Ingo Molnar
2016-05-06 15:21 ` Kees Cook
2016-05-06 10:36 ` Ingo Molnar
2016-05-06 10:44 ` Borislav Petkov [this message]
2016-05-06 11:50 ` [PATCH -v1.1] x86/boot: Simplify pointer casting in choose_random_location() Borislav Petkov
2016-05-07 6:35 ` [tip:x86/boot] " tip-bot for Borislav Petkov
2016-05-05 22:13 ` [PATCH v6 02/11] x86/KASLR: Consolidate mem_avoid entries Kees Cook
2016-05-06 7:46 ` [tip:x86/boot] x86/KASLR: Consolidate mem_avoid[] entries tip-bot for Yinghai Lu
2016-05-06 16:08 ` Borislav Petkov
2016-05-06 18:16 ` Kees Cook
2016-05-06 19:29 ` Borislav Petkov
2016-05-05 22:13 ` [PATCH v6 03/11] x86/boot: Split out kernel_ident_mapping_init Kees Cook
2016-05-05 22:13 ` [PATCH v6 04/11] x86/KASLR: Build identity mappings on demand Kees Cook
2016-05-06 7:00 ` Ingo Molnar
2016-05-06 17:44 ` Kees Cook
2016-05-05 22:13 ` [PATCH v6 05/11] x86/KASLR: Add slot_area to manage random_addr slots Kees Cook
2016-05-05 22:13 ` [PATCH v6 06/11] x86/KASLR: Return earliest overlap when avoiding regions Kees Cook
2016-05-05 22:13 ` [PATCH v6 07/11] x86/KASLR: Add virtual address choosing function Kees Cook
2016-05-05 22:13 ` [PATCH v6 08/11] x86/KASLR: Clarify purpose of each get_random_long Kees Cook
2016-05-05 22:13 ` [PATCH v6 09/11] x86/KASLR: Randomize virtual address separately Kees Cook
2016-05-05 22:13 ` [PATCH v6 10/11] x86/KASLR: Add physical address randomization >4G Kees Cook
2016-05-06 8:27 ` Baoquan He
2016-05-06 15:31 ` Kees Cook
2016-05-08 9:17 ` Baoquan He
2016-05-05 22:13 ` [PATCH v6 11/11] x86/KASLR: Allow randomization below load address Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506104438.GF24044@pd.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome