* [PATCH] fs: befs: use flags field to validate fs state
@ 2016-05-10 18:59 Salah Triki
2016-05-10 19:15 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2016-05-10 18:59 UTC (permalink / raw)
To: akpm; +Cc: Salah Triki, linux-kernel
flags field records the state of the superblock, so it is
more appropriate to use this field for validating the fs state than
using the fields log_start and log_end.
Signed-off-by: Salah Triki <salah.triki@acm.org>
---
fs/befs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/befs/super.c b/fs/befs/super.c
index aeafc4d..079fc00 100644
--- a/fs/befs/super.c
+++ b/fs/befs/super.c
@@ -101,7 +101,7 @@ befs_check_sb(struct super_block *sb)
return BEFS_ERR;
}
- if (befs_sb->log_start != befs_sb->log_end) {
+ if (befs_sb->flags == BFS_DIRTY) {
befs_error(sb, "Filesystem not clean! There are blocks in the "
"journal. You must boot into BeOS and mount this volume "
"to make it clean.");
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fs: befs: use flags field to validate fs state
2016-05-10 18:59 [PATCH] fs: befs: use flags field to validate fs state Salah Triki
@ 2016-05-10 19:15 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2016-05-10 19:15 UTC (permalink / raw)
To: Salah Triki; +Cc: linux-kernel
On Tue, 10 May 2016 19:59:42 +0100 Salah Triki <salah.triki@acm.org> wrote:
> flags field records the state of the superblock, so it is
> more appropriate to use this field for validating the fs state than
> using the fields log_start and log_end.
>
> Signed-off-by: Salah Triki <salah.triki@acm.org>
> ---
> fs/befs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index aeafc4d..079fc00 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -101,7 +101,7 @@ befs_check_sb(struct super_block *sb)
> return BEFS_ERR;
> }
>
> - if (befs_sb->log_start != befs_sb->log_end) {
> + if (befs_sb->flags == BFS_DIRTY) {
> befs_error(sb, "Filesystem not clean! There are blocks in the "
> "journal. You must boot into BeOS and mount this volume "
> "to make it clean.");
Has this been tested?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-10 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 18:59 [PATCH] fs: befs: use flags field to validate fs state Salah Triki
2016-05-10 19:15 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®