From: Mark Brown <broonie@kernel.org>
To: Venkat Reddy Talla <vreddytalla@nvidia.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, ldewangan@nvidia.com
Subject: Re: [PATCH 1/1] regulator: max77620: check for valid regulator info
Date: Mon, 27 Jun 2016 17:14:05 +0100 [thread overview]
Message-ID: <20160627161405.GA17217@sirena.org.uk> (raw)
In-Reply-To: <1467027824-29739-1-git-send-email-vreddytalla@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote:
> Check for valid regulator information data before
> configuring FPS source and FPS power up/down
> period to avoid NULL pointer exception if entries for
> PMIC regulators not provided through device tree.
This sounds like it's papering over a bug in the driver - the driver
should be able to instantiate without anything beyond the registration
of the device. What's the driver relying on from the DT?
> SD4 regulator is not supported by MAX77620 PMIC, removing
> SD4 entry from regulator information list.
This appears to be a separate change to the above and should be a
separate patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-27 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 11:43 Venkat Reddy Talla
2016-06-27 16:14 ` Mark Brown [this message]
2016-06-28 4:35 ` Venkat Reddy Talla
2016-06-28 19:30 ` Mark Brown
2016-06-29 18:04 ` Applied "regulator: max77620: check for valid regulator info" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627161405.GA17217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vreddytalla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®