mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Venkat Reddy Talla <vreddytalla@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Laxman Dewangan" <ldewangan@nvidia.com>
Subject: RE: [PATCH 1/1] regulator: max77620: check for valid regulator info
Date: Tue, 28 Jun 2016 04:35:56 +0000	[thread overview]
Message-ID: <3bdeadd747c8475b991183fe9f094e62@bgmail102.nvidia.com> (raw)
In-Reply-To: <20160627161405.GA17217@sirena.org.uk>

> * PGP Signed by an unknown key
> 
> On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote:
> > Check for valid regulator information data before configuring FPS
> > source and FPS power up/down period to avoid NULL pointer exception if
> > entries for PMIC regulators not provided through device tree.
> 
> This sounds like it's papering over a bug in the driver - the driver should be
> able to instantiate without anything beyond the registration of the device.
> What's the driver relying on from the DT?
> 
Sorry for confusion, there is no dependent on DTS entry, I mean, in probe
SD4 regulator for MAX77620 PMIC is not registered with regulator core framework so
Regulator info will be null.

> > SD4 regulator is not supported by MAX77620 PMIC, removing
> > SD4 entry from regulator information list.
> 
> This appears to be a separate change to the above and should be a separate
> patch.
> 
Regulator info data will be null since SD4 regulator is not getting registered with core framework,
MAX77620 not supporting SD4 regulator, due to this reason I have included this change as part of this patch.
I will change the commit message and push another patch on top of this patch.

Thanks for review.

> * Unknown Key
> * 0x5D5487D0

  reply	other threads:[~2016-06-28  4:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 11:43 Venkat Reddy Talla
2016-06-27 16:14 ` Mark Brown
2016-06-28  4:35   ` Venkat Reddy Talla [this message]
2016-06-28 19:30     ` Mark Brown
2016-06-29 18:04 ` Applied "regulator: max77620: check for valid regulator info" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bdeadd747c8475b991183fe9f094e62@bgmail102.nvidia.com \
    --to=vreddytalla@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®