From: David Miller <davem@davemloft.net>
To: john.stultz@linaro.org
Cc: mateusz.bajorski@nokia.com, dsa@cumulusnetworks.com,
linux-kernel@vger.kernel.org, guodong.xu@linaro.org,
dimitrysh@google.com
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace
Date: Thu, 28 Jul 2016 21:20:31 -0700 (PDT) [thread overview]
Message-ID: <20160728.212031.549387302791502368.davem@davemloft.net> (raw)
In-Reply-To: <CALAqxLUrJ86pJ20ppTycG3e2wv=zegC6UfQdXtnjeQYxQw2iMg@mail.gmail.com>
From: John Stultz <john.stultz@linaro.org>
Date: Thu, 28 Jul 2016 21:18:16 -0700
> After moving my HiKey tree to pre-v4.8-rc, I noticed when using
> Android that I was getting routing errors after toggling networking on
> and off (or entering suspend). Wifi associated, but I got some
> rounting errors in the logcat the connection manager wouldn't detect a
> valid network.
>
> Not being able to figure out exactly what was going wrong from the
> userspace side, I bisected (manually rebasing a 70 patch stack each
> step :P) it down and it seems that the commit: 153380ec4b9b
> ("fib_rules: Added NLM_F_EXCL support to fib_nl_newrule") is causing
> the problem.
>
> Reverting that patch seems to make things work again.
>
> I'm no networking guru, but I'm happy to help debug this further if
> folks can walk me through it a bit.
It simply sounds like Android's userspace is specifying NLM_F_EXCL when
it shouldn't be during FIB rule netlink operations.
next prev parent reply other threads:[~2016-07-29 4:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 4:18 John Stultz
2016-07-29 4:20 ` David Miller [this message]
2016-07-29 14:12 ` David Ahern
2016-07-29 16:57 ` John Stultz
2016-07-29 19:10 ` David Ahern
2016-08-01 1:42 ` Lorenzo Colitti
2016-08-02 16:37 ` John Stultz
2016-08-02 17:03 ` John Stultz
2016-08-02 17:09 ` David Ahern
2016-08-02 17:51 ` John Stultz
2016-08-02 18:00 ` David Miller
2016-08-02 18:22 ` John Stultz
2016-08-02 18:28 ` David Miller
2016-08-03 0:58 ` Lorenzo Colitti
2016-08-03 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728.212031.549387302791502368.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dimitrysh@google.com \
--cc=dsa@cumulusnetworks.com \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.bajorski@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®