From: David Ahern <dsa@cumulusnetworks.com>
To: John Stultz <john.stultz@linaro.org>
Cc: David Miller <davem@davemloft.net>,
Mateusz Bajorski <mateusz.bajorski@nokia.com>,
lkml <linux-kernel@vger.kernel.org>,
Guodong Xu <guodong.xu@linaro.org>,
Dmitry Shmidt <dimitrysh@google.com>,
Chih-Hung Hsieh <chh@google.com>,
Eric Caruso <ejcaruso@google.com>,
Lorenzo Colitti <lorenzo@google.com>
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace
Date: Fri, 29 Jul 2016 13:10:10 -0600 [thread overview]
Message-ID: <54c59314-8f0e-542d-93e6-7953cbcd430e@cumulusnetworks.com> (raw)
In-Reply-To: <CALAqxLWBFyS8VF02tBmAR-Zu1j6Nh7ETZFoWx1fzVgx81rUk1Q@mail.gmail.com>
On 7/29/16 10:57 AM, John Stultz wrote:
>> I take Android userspace inserts the same rule multiple times? (ip rule ls)
>
> With the patch reverted, and the system working, I see:
>
> # ip rule ls
> 0: from all lookup local
> 10000: from all fwmark 0xc0000/0xd0000 lookup legacy_system
> 13000: from all fwmark 0x10063/0x1ffff lookup local_network
> 13000: from all fwmark 0x10065/0x1ffff lookup wlan0
> 14000: from all oif wlan0 lookup wlan0
> 14000: from all oif wlan0 lookup wlan0
duplicate rules.
> 15000: from all fwmark 0x0/0x10000 lookup legacy_system
> 16000: from all fwmark 0x0/0x10000 lookup legacy_network
> 17000: from all fwmark 0x0/0x10000 lookup local_network
> 19000: from all fwmark 0x64/0x1ffff lookup wlan0
> 19000: from all fwmark 0x65/0x1ffff lookup wlan0
> 22000: from all fwmark 0x0/0xffff lookup wlan0
> 32000: from all unreachable
>
> With the patch applied, and after toggling wifi, when I see the problem:
>
> # ip rule ls
> 0: from all lookup local
> 10000: from all fwmark 0xc0000/0xd0000 lookup legacy_system
> 13000: from all fwmark 0x10063/0x1ffff lookup local_network
> 13000: from all fwmark 0x10065/0x1ffff lookup wlan0
> 14000: from all oif wlan0 lookup wlan0
The failure would be happening on the insertion of the second wlan0 rule.
> 15000: from all fwmark 0x0/0x10000 lookup legacy_system
> 16000: from all fwmark 0x0/0x10000 lookup legacy_network
> 17000: from all fwmark 0x0/0x10000 lookup local_network
> 19000: from all fwmark 0x64/0x1ffff lookup wlan0
> 32000: from all unreachable
>
>
>> If so and multiple components expect to manage their own 'copy' of the rule
>> they will need to remove the NLM_F_EXCL flag.
>
> Adding more networky Android folks to the CC.
>
> thanks
> -john
>
next prev parent reply other threads:[~2016-07-29 19:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 4:18 John Stultz
2016-07-29 4:20 ` David Miller
2016-07-29 14:12 ` David Ahern
2016-07-29 16:57 ` John Stultz
2016-07-29 19:10 ` David Ahern [this message]
2016-08-01 1:42 ` Lorenzo Colitti
2016-08-02 16:37 ` John Stultz
2016-08-02 17:03 ` John Stultz
2016-08-02 17:09 ` David Ahern
2016-08-02 17:51 ` John Stultz
2016-08-02 18:00 ` David Miller
2016-08-02 18:22 ` John Stultz
2016-08-02 18:28 ` David Miller
2016-08-03 0:58 ` Lorenzo Colitti
2016-08-03 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54c59314-8f0e-542d-93e6-7953cbcd430e@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=chh@google.com \
--cc=davem@davemloft.net \
--cc=dimitrysh@google.com \
--cc=ejcaruso@google.com \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=mateusz.bajorski@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®