From: David Ahern <dsa@cumulusnetworks.com>
To: John Stultz <john.stultz@linaro.org>,
Lorenzo Colitti <lorenzo@google.com>
Cc: David Miller <davem@davemloft.net>,
Mateusz Bajorski <mateusz.bajorski@nokia.com>,
lkml <linux-kernel@vger.kernel.org>,
Guodong Xu <guodong.xu@linaro.org>,
Dmitry Shmidt <dimitrysh@google.com>,
Chih-Hung Hsieh <chh@google.com>,
Eric Caruso <ejcaruso@google.com>
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace
Date: Tue, 2 Aug 2016 11:09:04 -0600 [thread overview]
Message-ID: <fb4e3c33-b2d3-00f3-3f2d-dcc4a641d53f@cumulusnetworks.com> (raw)
In-Reply-To: <CALAqxLW1Ge5ZeCEBnP=+0cT1wjQUrXozQc0fEwtmmGs6UQ6eEg@mail.gmail.com>
On 8/2/16 11:03 AM, John Stultz wrote:
> So bisecting between v4.7 and linus/HEAD with the test above, it seems like:
> 96c63fa7393d ("net: Add l3mdev rule") is what breaks the tests.
>
> The l3mdev rule patch is a bit tangled with the fib_rules one, but if
> I revert both of those, the only thing that fails is the
> ./neighbour_test.py (which I need to dig further into). But those two
> changes seem to be connected to the regression I'm seeing with
> Android.
That is surprising since the l3mdev rule should not exist on Android
unless it has created a VRF.
Does Android have custom FRA types in <linux/fib_rules.h>? Perhaps there
is a collision on attribute number?
next prev parent reply other threads:[~2016-08-02 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 4:18 John Stultz
2016-07-29 4:20 ` David Miller
2016-07-29 14:12 ` David Ahern
2016-07-29 16:57 ` John Stultz
2016-07-29 19:10 ` David Ahern
2016-08-01 1:42 ` Lorenzo Colitti
2016-08-02 16:37 ` John Stultz
2016-08-02 17:03 ` John Stultz
2016-08-02 17:09 ` David Ahern [this message]
2016-08-02 17:51 ` John Stultz
2016-08-02 18:00 ` David Miller
2016-08-02 18:22 ` John Stultz
2016-08-02 18:28 ` David Miller
2016-08-03 0:58 ` Lorenzo Colitti
2016-08-03 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb4e3c33-b2d3-00f3-3f2d-dcc4a641d53f@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=chh@google.com \
--cc=davem@davemloft.net \
--cc=dimitrysh@google.com \
--cc=ejcaruso@google.com \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=mateusz.bajorski@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®