From: Daniel Vetter <daniel@ffwll.ch>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
Mali DP Maintainers <malidp@foss.arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()
Date: Thu, 28 Jul 2016 12:59:43 +0200 [thread overview]
Message-ID: <20160728105943.GJ6232@phenom.ffwll.local> (raw)
In-Reply-To: <20160728081143.GD8609@e106497-lin.cambridge.arm.com>
On Thu, Jul 28, 2016 at 09:11:43AM +0100, Liviu Dudau wrote:
> On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote:
> > There is a error message within devm_ioremap_resource
> > already, so remove the DRM_ERROR call to avoid redundant
> > error message.
>
> Yeah, good catch!
>
> >
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Applied to drm-misc, thanks.
-Daniel
>
>
> Thanks for the cleanup!
> Liviu
>
> > ---
> > drivers/gpu/drm/arm/malidp_drv.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..1160322 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
> >
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > hwdev->regs = devm_ioremap_resource(dev, res);
> > - if (IS_ERR(hwdev->regs)) {
> > - DRM_ERROR("Failed to map control registers area\n");
> > + if (IS_ERR(hwdev->regs))
> > return PTR_ERR(hwdev->regs);
> > - }
> >
> > hwdev->pclk = devm_clk_get(dev, "pclk");
> > if (IS_ERR(hwdev->pclk))
> >
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-07-28 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 2:09 Wei Yongjun
2016-07-28 8:11 ` Liviu Dudau
2016-07-28 10:59 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728105943.GJ6232@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=malidp@foss.arm.com \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®