mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()
@ 2016-07-28  2:09 Wei Yongjun
  2016-07-28  8:11 ` Liviu Dudau
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2016-07-28  2:09 UTC (permalink / raw)
  To: Liviu Dudau, Brian Starkey, Mali DP Maintainers, David Airlie
  Cc: Wei Yongjun, dri-devel, linux-kernel

There is a error message within devm_ioremap_resource
already, so remove the DRM_ERROR call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/gpu/drm/arm/malidp_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 4e61ea5..1160322 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	hwdev->regs = devm_ioremap_resource(dev, res);
-	if (IS_ERR(hwdev->regs)) {
-		DRM_ERROR("Failed to map control registers area\n");
+	if (IS_ERR(hwdev->regs))
 		return PTR_ERR(hwdev->regs);
-	}
 
 	hwdev->pclk = devm_clk_get(dev, "pclk");
 	if (IS_ERR(hwdev->pclk))

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()
  2016-07-28  2:09 [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Wei Yongjun
@ 2016-07-28  8:11 ` Liviu Dudau
  2016-07-28 10:59   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Liviu Dudau @ 2016-07-28  8:11 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Brian Starkey, Mali DP Maintainers, David Airlie, dri-devel,
	linux-kernel

On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the DRM_ERROR call to avoid redundant
> error message.

Yeah, good catch!

> 
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>


Thanks for the cleanup!
Liviu

> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 4e61ea5..1160322 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	hwdev->regs = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(hwdev->regs)) {
> -		DRM_ERROR("Failed to map control registers area\n");
> +	if (IS_ERR(hwdev->regs))
>  		return PTR_ERR(hwdev->regs);
> -	}
>  
>  	hwdev->pclk = devm_clk_get(dev, "pclk");
>  	if (IS_ERR(hwdev->pclk))
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()
  2016-07-28  8:11 ` Liviu Dudau
@ 2016-07-28 10:59   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-07-28 10:59 UTC (permalink / raw)
  To: Liviu Dudau; +Cc: Wei Yongjun, Mali DP Maintainers, dri-devel, linux-kernel

On Thu, Jul 28, 2016 at 09:11:43AM +0100, Liviu Dudau wrote:
> On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote:
> > There is a error message within devm_ioremap_resource
> > already, so remove the DRM_ERROR call to avoid redundant
> > error message.
> 
> Yeah, good catch!
> 
> > 
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> 
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

Applied to drm-misc, thanks.
-Daniel

> 
> 
> Thanks for the cleanup!
> Liviu
> 
> > ---
> >  drivers/gpu/drm/arm/malidp_drv.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..1160322 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
> >  
> >  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >  	hwdev->regs = devm_ioremap_resource(dev, res);
> > -	if (IS_ERR(hwdev->regs)) {
> > -		DRM_ERROR("Failed to map control registers area\n");
> > +	if (IS_ERR(hwdev->regs))
> >  		return PTR_ERR(hwdev->regs);
> > -	}
> >  
> >  	hwdev->pclk = devm_clk_get(dev, "pclk");
> >  	if (IS_ERR(hwdev->pclk))
> > 
> 
> -- 
> ====================
> | I would like to |
> | fix the world,  |
> | but they're not |
> | giving me the   |
>  \ source code!  /
>   ---------------
>     ¯\_(ツ)_/¯
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-28 10:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28  2:09 [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Wei Yongjun
2016-07-28  8:11 ` Liviu Dudau
2016-07-28 10:59   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®