From: Baole Ni <baolex.ni@intel.com>
To: rubini@gnudd.com, ccross@android.com, keescook@chromium.org,
tony.luck@intel.com, matt@codeblueprint.co.uk,
m.chehab@samsung.com, lho@apm.com, dougthompson@xmission.com,
bp@alien8.de
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com,
baolex.ni@intel.com, lee.jones@linaro.org
Subject: [PATCH 0174/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 18:46:40 +0800 [thread overview]
Message-ID: <20160802104640.25338-1-baolex.ni@intel.com> (raw)
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/fmc/fmc-fakedev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fmc/fmc-fakedev.c b/drivers/fmc/fmc-fakedev.c
index 941d093..2ace110 100644
--- a/drivers/fmc/fmc-fakedev.c
+++ b/drivers/fmc/fmc-fakedev.c
@@ -26,11 +26,11 @@
/* The user can pass up to 4 names of eeprom images to load */
static char *ff_eeprom[FF_MAX_MEZZANINES];
static int ff_nr_eeprom;
-module_param_array_named(eeprom, ff_eeprom, charp, &ff_nr_eeprom, 0444);
+module_param_array_named(eeprom, ff_eeprom, charp, &ff_nr_eeprom, S_IRUSR | S_IRGRP | S_IROTH);
/* The user can ask for a multi-mezzanine carrier, with the default eeprom */
static int ff_nr_dev = 1;
-module_param_named(ndev, ff_nr_dev, int, 0444);
+module_param_named(ndev, ff_nr_dev, int, S_IRUSR | S_IRGRP | S_IROTH);
/* Lazily, don't support the "standard" module parameters */
--
2.9.2
reply other threads:[~2016-08-02 12:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802104640.25338-1-baolex.ni@intel.com \
--to=baolex.ni@intel.com \
--cc=bp@alien8.de \
--cc=ccross@android.com \
--cc=chuansheng.liu@intel.com \
--cc=dougthompson@xmission.com \
--cc=keescook@chromium.org \
--cc=lee.jones@linaro.org \
--cc=lho@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=matt@codeblueprint.co.uk \
--cc=rubini@gnudd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®