mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0174/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:46 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 10:46 UTC (permalink / raw)
  To: rubini, ccross, keescook, tony.luck, matt, m.chehab, lho,
	dougthompson, bp
  Cc: linux-kernel, chuansheng.liu, baolex.ni, lee.jones

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/fmc/fmc-fakedev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/fmc/fmc-fakedev.c b/drivers/fmc/fmc-fakedev.c
index 941d093..2ace110 100644
--- a/drivers/fmc/fmc-fakedev.c
+++ b/drivers/fmc/fmc-fakedev.c
@@ -26,11 +26,11 @@
 /* The user can pass up to 4 names of eeprom images to load */
 static char *ff_eeprom[FF_MAX_MEZZANINES];
 static int ff_nr_eeprom;
-module_param_array_named(eeprom, ff_eeprom, charp, &ff_nr_eeprom, 0444);
+module_param_array_named(eeprom, ff_eeprom, charp, &ff_nr_eeprom, S_IRUSR | S_IRGRP | S_IROTH);
 
 /* The user can ask for a multi-mezzanine carrier, with the default eeprom */
 static int ff_nr_dev = 1;
-module_param_named(ndev, ff_nr_dev, int, 0444);
+module_param_named(ndev, ff_nr_dev, int, S_IRUSR | S_IRGRP | S_IROTH);
 
 
 /* Lazily, don't support the "standard" module parameters */
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 12:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:46 [PATCH 0174/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®