* [PATCH 0243/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:52 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 10:52 UTC (permalink / raw)
To: alexander.shishkin, jdelvare, linux, airlied, kgene, k.kozlowski,
dougthompson, bp
Cc: linux-kernel, chuansheng.liu, baolex.ni, aduggan, dianders
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/hwtracing/stm/heartbeat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/stm/heartbeat.c b/drivers/hwtracing/stm/heartbeat.c
index 3da7b67..92b3726 100644
--- a/drivers/hwtracing/stm/heartbeat.c
+++ b/drivers/hwtracing/stm/heartbeat.c
@@ -26,8 +26,8 @@
static int nr_devs = 4;
static int interval_ms = 10;
-module_param(nr_devs, int, 0400);
-module_param(interval_ms, int, 0600);
+module_param(nr_devs, int, S_IRUSR);
+module_param(interval_ms, int, S_IRUSR | S_IWUSR);
static struct stm_heartbeat {
struct stm_source_data data;
--
2.9.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 11:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:52 [PATCH 0243/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®