mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0490/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:17 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:17 UTC (permalink / raw)
  To: mchehab, maurochehab, mchehab, mchehab, m.chehab, awalls, a.hajda, bp
  Cc: linux-media, linux-kernel, chuansheng.liu, baolex.ni, sw0312.kim,
	jh1009.sung

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/pci/meye/meye.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c
index ba887e8..8283113 100644
--- a/drivers/media/pci/meye/meye.c
+++ b/drivers/media/pci/meye/meye.c
@@ -54,18 +54,18 @@ MODULE_VERSION(MEYE_DRIVER_VERSION);
 
 /* number of grab buffers */
 static unsigned int gbuffers = 2;
-module_param(gbuffers, int, 0444);
+module_param(gbuffers, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(gbuffers, "number of capture buffers, default is 2 (32 max)");
 
 /* size of a grab buffer */
 static unsigned int gbufsize = MEYE_MAX_BUFSIZE;
-module_param(gbufsize, int, 0444);
+module_param(gbufsize, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(gbufsize, "size of the capture buffers, default is 614400"
 		 " (will be rounded up to a page multiple)");
 
 /* /dev/videoX registration number */
 static int video_nr = -1;
-module_param(video_nr, int, 0444);
+module_param(video_nr, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(video_nr, "video device to register (0=/dev/video0, etc)");
 
 /* driver structure - only one possible */
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 17:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:17 [PATCH 0490/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®