mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0527/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:21 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:21 UTC (permalink / raw)
  To: mchehab, maurochehab, mchehab, mchehab, m.chehab, corbet,
	s.nawrocki, kgene, k.kozlowski
  Cc: linux-media, linux-kernel, chuansheng.liu, baolex.ni,
	jh1009.sung, nenggun.kim

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/platform/marvell-ccic/mcam-core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
index 9b878de..4b3515c 100644
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -47,7 +47,7 @@
  */
 
 static bool alloc_bufs_at_read;
-module_param(alloc_bufs_at_read, bool, 0444);
+module_param(alloc_bufs_at_read, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(alloc_bufs_at_read,
 		"Non-zero value causes DMA buffers to be allocated when the "
 		"video capture device is read, rather than at module load "
@@ -56,13 +56,13 @@ MODULE_PARM_DESC(alloc_bufs_at_read,
 		"only used in the vmalloc buffer mode");
 
 static int n_dma_bufs = 3;
-module_param(n_dma_bufs, uint, 0644);
+module_param(n_dma_bufs, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(n_dma_bufs,
 		"The number of DMA buffers to allocate.  Can be either two "
 		"(saves memory, makes timing tighter) or three.");
 
 static int dma_buf_size = VGA_WIDTH * VGA_HEIGHT * 2;  /* Worst case */
-module_param(dma_buf_size, uint, 0444);
+module_param(dma_buf_size, uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(dma_buf_size,
 		"The size of the allocated DMA buffers.  If actual operating "
 		"parameters require larger buffers, an attempt to reallocate "
@@ -73,13 +73,13 @@ static const int n_dma_bufs = 3;  /* Used by S/G_PARM */
 #endif /* MCAM_MODE_VMALLOC */
 
 static bool flip;
-module_param(flip, bool, 0444);
+module_param(flip, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(flip,
 		"If set, the sensor will be instructed to flip the image "
 		"vertically.");
 
 static int buffer_mode = -1;
-module_param(buffer_mode, int, 0444);
+module_param(buffer_mode, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(buffer_mode,
 		"Set the buffer mode to be used; default is to go with what "
 		"the platform driver asks for.  Set to 0 for vmalloc, 1 for "
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 16:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:21 [PATCH 0527/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®