* [PATCH 0662/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:34 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:34 UTC (permalink / raw)
To: mchehab, maurochehab, mchehab, mchehab, m.chehab, royale,
hdegoede, kgene, k.kozlowski
Cc: linux-media, linux-kernel, hans.verkuil, laurent.pinchart,
chuansheng.liu, baolex.ni
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/media/v4l2-core/tuner-core.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c
index 731487b..2d029d2 100644
--- a/drivers/media/v4l2-core/tuner-core.c
+++ b/drivers/media/v4l2-core/tuner-core.c
@@ -54,9 +54,9 @@ static unsigned int addr;
static unsigned int no_autodetect;
static unsigned int show_i2c;
-module_param(addr, int, 0444);
-module_param(no_autodetect, int, 0444);
-module_param(show_i2c, int, 0444);
+module_param(addr, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(no_autodetect, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(show_i2c, int, S_IRUSR | S_IRGRP | S_IROTH);
/* insmod options used at runtime => read/write */
static int tuner_debug;
@@ -66,12 +66,12 @@ static char pal[] = "--";
static char secam[] = "--";
static char ntsc[] = "-";
-module_param_named(debug, tuner_debug, int, 0644);
-module_param_array(tv_range, int, NULL, 0644);
-module_param_array(radio_range, int, NULL, 0644);
-module_param_string(pal, pal, sizeof(pal), 0644);
-module_param_string(secam, secam, sizeof(secam), 0644);
-module_param_string(ntsc, ntsc, sizeof(ntsc), 0644);
+module_param_named(debug, tuner_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_array(tv_range, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_array(radio_range, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_string(pal, pal, sizeof(pal), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_string(secam, secam, sizeof(secam), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_string(ntsc, ntsc, sizeof(ntsc), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
/*
* Static vars
--
2.9.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 12:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:34 [PATCH 0662/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®