mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0705/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:38 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:38 UTC (permalink / raw)
  To: kyungmin.park, dwmw2, computersforpeace, m.chehab, pawel,
	m.szyprowski, k.kozlowski
  Cc: linux-mtd, linux-kernel, chuansheng.liu, baolex.ni, grundler, lporzio

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/mtd/onenand/onenand_base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index a4b029a..7f944e6 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -44,7 +44,7 @@
 /* Default Flex-OneNAND boundary and lock respectively */
 static int flex_bdry[MAX_DIES * 2] = { -1, 0, -1, 0 };
 
-module_param_array(flex_bdry, int, NULL, 0400);
+module_param_array(flex_bdry, int, NULL, S_IRUSR);
 MODULE_PARM_DESC(flex_bdry,	"SLC Boundary information for Flex-OneNAND"
 				"Syntax:flex_bdry=DIE_BDRY,LOCK,..."
 				"DIE_BDRY: SLC boundary of the die"
@@ -55,7 +55,7 @@ MODULE_PARM_DESC(flex_bdry,	"SLC Boundary information for Flex-OneNAND"
 /* Default OneNAND/Flex-OneNAND OTP options*/
 static int otp;
 
-module_param(otp, int, 0400);
+module_param(otp, int, S_IRUSR);
 MODULE_PARM_DESC(otp,	"Corresponding behaviour of OneNAND in OTP"
 			"Syntax : otp=LOCK_TYPE"
 			"LOCK_TYPE : Keys issued, for specific OTP Lock type"
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 16:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:38 [PATCH 0705/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®