* [PATCH 0980/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:04 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:04 UTC (permalink / raw)
To: balbi, gregkh, m.chehab, m.szyprowski, kyungmin.park, k.kozlowski
Cc: linux-usb, linux-kernel, r.baldyga, heikki.krogerus,
yousaf.kaukab, chuansheng.liu, baolex.ni, nicstange, oneukum
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/usb/gadget/udc/net2280.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index c894b94..58a741f 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -133,7 +133,7 @@ static const struct {
static ushort fifo_mode;
/* "modprobe net2280 fifo_mode=1" etc */
-module_param(fifo_mode, ushort, 0644);
+module_param(fifo_mode, ushort, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
/* enable_suspend -- When enabled, the driver will respond to
* USB suspend requests by powering down the NET2280. Otherwise,
@@ -143,7 +143,7 @@ module_param(fifo_mode, ushort, 0644);
static bool enable_suspend;
/* "modprobe net2280 enable_suspend=1" etc */
-module_param(enable_suspend, bool, 0444);
+module_param(enable_suspend, bool, S_IRUSR | S_IRGRP | S_IROTH);
#define DIR_STRING(bAddress) (((bAddress) & USB_DIR_IN) ? "in" : "out")
--
2.9.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 14:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:04 [PATCH 0980/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®