mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1085/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:15 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:15 UTC (permalink / raw)
  To: ericvh, rminnich, lucho, davem, jiangshanlai, m.chehab, gregkh,
	m.szyprowski, kyungmin.park, k.kozlowski
  Cc: v9fs-developer, netdev, linux-kernel, chuansheng.liu, baolex.ni,
	gang.chen.5i5j, mhocko, koct9i, aarcange, aryabinin

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 net/9p/trans_virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index 4acb1d5..f5ae921 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -527,7 +527,7 @@ static ssize_t p9_mount_tag_show(struct device *dev,
 	return chan->tag_len + 1;
 }
 
-static DEVICE_ATTR(mount_tag, 0444, p9_mount_tag_show, NULL);
+static DEVICE_ATTR(mount_tag, S_IRUSR | S_IRGRP | S_IROTH, p9_mount_tag_show, NULL);
 
 /**
  * p9_virtio_probe - probe for existence of 9P virtio channels
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 14:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:15 [PATCH 1085/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®