From: Suman Anna <s-anna@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Suman Anna <s-anna@ti.com>
Subject: [PATCH 06/13] remoteproc: print hex numbers with a leading 0x format
Date: Fri, 12 Aug 2016 18:42:21 -0500 [thread overview]
Message-ID: <20160812234228.39731-7-s-anna@ti.com> (raw)
In-Reply-To: <20160812234228.39731-1-s-anna@ti.com>
There are couple of debug statements that are printing hexadecimal
numbers without the leading 0x. Fix these and use the standard 0x%x
format specifier so that there is no confusion when looking at the
traces.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
drivers/remoteproc/remoteproc_core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index fb92b8084a4e..0f85f7eb476d 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -236,7 +236,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
}
notifyid = ret;
- dev_dbg(dev, "vring%d: va %p dma %pad size %x idr %d\n",
+ dev_dbg(dev, "vring%d: va %p dma %pad size 0x%x idr %d\n",
i, va, &dma, size, notifyid);
rvring->va = va;
@@ -263,7 +263,7 @@ rproc_parse_vring(struct rproc_vdev *rvdev, struct fw_rsc_vdev *rsc, int i)
struct fw_rsc_vdev_vring *vring = &rsc->vring[i];
struct rproc_vring *rvring = &rvdev->vring[i];
- dev_dbg(dev, "vdev rsc: vring%d: da %x, qsz %d, align %d\n",
+ dev_dbg(dev, "vdev rsc: vring%d: da 0x%x, qsz %d, align %d\n",
i, vring->da, vring->num, vring->align);
/* make sure reserved bytes are zeroes */
@@ -349,7 +349,7 @@ static int rproc_handle_vdev(struct rproc *rproc, struct fw_rsc_vdev *rsc,
return -EINVAL;
}
- dev_dbg(dev, "vdev rsc: id %d, dfeatures %x, cfg len %d, %d vrings\n",
+ dev_dbg(dev, "vdev rsc: id %d, dfeatures 0x%x, cfg len %d, %d vrings\n",
rsc->id, rsc->dfeatures, rsc->config_len, rsc->num_of_vrings);
/* we currently support only two vrings per rvdev */
@@ -578,7 +578,7 @@ static int rproc_handle_carveout(struct rproc *rproc,
return -EINVAL;
}
- dev_dbg(dev, "carveout rsc: name: %s, da %x, pa %x, len 0x%x, flags %x\n",
+ dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n",
rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags);
carveout = kzalloc(sizeof(*carveout), GFP_KERNEL);
--
2.9.0
next prev parent reply other threads:[~2016-08-12 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 23:42 [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Suman Anna
2016-08-12 23:42 ` [PATCH 01/13] remoteproc: use proper format-specifier for printing dma_addr_t Suman Anna
2016-08-12 23:42 ` [PATCH 02/13] remoteproc: fix couple of minor typos Suman Anna
2016-08-12 23:42 ` [PATCH 03/13] remoteproc: use variable names for sizeof() operator Suman Anna
2016-08-12 23:42 ` [PATCH 04/13] remoteproc: fix bare unsigned type usage Suman Anna
2016-08-12 23:42 ` [PATCH 05/13] remoteproc: align code with open parenthesis Suman Anna
2016-08-12 23:42 ` Suman Anna [this message]
2016-08-12 23:42 ` [PATCH 07/13] remoteproc/omap: fix various code formatting issues Suman Anna
2016-08-12 23:42 ` [PATCH 08/13] remoteproc/omap: revise a minor error trace message Suman Anna
2016-08-12 23:42 ` [PATCH 09/13] rpmsg: remove pointless OOM prints Suman Anna
2016-08-12 23:42 ` [PATCH 10/13] rpmsg: use proper format-specifier for printing dma_addr_t Suman Anna
2016-08-12 23:42 ` [PATCH 11/13] rpmsg: align code with open parenthesis Suman Anna
2016-08-12 23:42 ` [PATCH 12/13] rpmsg: use dynamic_hex_dump for hex dump traces Suman Anna
2016-08-12 23:42 ` [PATCH 13/13] samples/rpmsg: add support for multiple instances Suman Anna
2016-08-13 5:10 ` [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812234228.39731-7-s-anna@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®